From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from sonic301-36.consmr.mail.ir2.yahoo.com ([77.238.176.113]:40224
        "EHLO sonic301-36.consmr.mail.ir2.yahoo.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1752345AbdJSUa5 (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 19 Oct 2017 16:30:57 -0400
Date: Thu, 19 Oct 2017 20:30:53 +0000 (UTC)
From: Hin-Tak Leung <htl10@users.sourceforge.net>
Reply-To: Hin-Tak Leung <htl10@users.sourceforge.net>
To: <linux-fsdevel@vger.kernel.org>,
        =?UTF-8?Q?Ernesto_A=2E_Fern=C3=A1ndez?=
        <ernesto.mnd.fernandez@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Hin-Tak Leung <htl10@users.sourceforge.net>,
        Vyacheslav Dubeyko <slava@dubeyko.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        =?UTF-8?Q?Ernesto_A=2E_Fern=C3=A1ndez?=
        <ernesto.mnd.fernandez@gmail.com>
Message-ID: <51697605.866452.1508445053840@mail.yahoo.com>
Subject: Re: [PATCH] hfsplus: return ENODATA when no xattr is found
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
References: <51697605.866452.1508445053840.ref@mail.yahoo.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>


--------------------------------------------
On Thu, 19/10/17, Ernesto A. Fern=C3=A1ndez <ernesto.mnd.fernandez@gmail.co=
m> wrote:

> There are several points in the code where ENOENT or
> EOPNOTSUPP are
> used to signal that an extended attribute does not exist.
> This is
> clearly noticeable from the odd error messages shown by
> setfattr and
> getfattr. Use ENODATA instead.
=20
> Signed-off-by: Ernesto A. Fern=C3=A1ndez <ernesto.mnd.fernandez@gmail.com=
>

Nacked.

I think you perhaps mis-understood the code. Some (older) HFS+ file system =
does not have attribute records so it gives  EOPNOTSUPP . It is not NODATA,=
 but that you cannot write attribute data(or read) to such old fs. Likewise=
, the other changes from ENOENT to ENODATA seems wrong too. "Not found" is =
not "no data" ( =3D "found but null").