* [PATCH 1/2] xfstests: dump _require_fio output to log
@ 2013-04-15 11:09 Dmitry Monakhov
2013-04-15 11:09 ` [PATCH 2/2] xfstests: fix fio's arguments Dmitry Monakhov
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dmitry Monakhov @ 2013-04-15 11:09 UTC (permalink / raw)
To: xfs; +Cc: linux-fsdevel, Dmitry Monakhov, linux-ext4, dchinner
This should helps to find incompatibility issues.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
common/rc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
mode change 100644 => 100755 tests/ext4/301
diff --git a/common/rc b/common/rc
index 09fb83f..ad3e378 100644
--- a/common/rc
+++ b/common/rc
@@ -1967,8 +1967,8 @@ _require_fio()
return 1;
fi
- $FIO_PROG --warnings-fatal --showcmd $job >/dev/null 2>&1
- [ $? -eq 0 ] || _notrun "$FIO_PROG too old"
+ $FIO_PROG --warnings-fatal --showcmd $job >> $seqres.full 2>&1
+ [ $? -eq 0 ] || _notrun "$FIO_PROG too old, see $seqres.full"
}
# Does freeze work on this fs?
diff --git a/tests/ext4/301 b/tests/ext4/301
old mode 100644
new mode 100755
--
1.7.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] xfstests: fix fio's arguments
2013-04-15 11:09 [PATCH 1/2] xfstests: dump _require_fio output to log Dmitry Monakhov
@ 2013-04-15 11:09 ` Dmitry Monakhov
2013-04-22 15:21 ` Rich Johnston
2013-04-22 15:31 ` Rich Johnston
2013-04-22 15:19 ` [PATCH 1/2] xfstests: dump _require_fio output to log Rich Johnston
2013-04-22 15:30 ` Rich Johnston
2 siblings, 2 replies; 6+ messages in thread
From: Dmitry Monakhov @ 2013-04-15 11:09 UTC (permalink / raw)
To: xfs; +Cc: linux-fsdevel, Dmitry Monakhov, linux-ext4, dchinner
Option 'group_reporting' semantics was changes for recent fio versions
In fact we do not need it here, let's just drop it.
Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
tests/ext4/301 | 1 -
tests/ext4/302 | 1 -
tests/ext4/303 | 1 -
tests/ext4/304 | 1 -
4 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/tests/ext4/301 b/tests/ext4/301
index b6c2f11..e1583d4 100755
--- a/tests/ext4/301
+++ b/tests/ext4/301
@@ -59,7 +59,6 @@ filesize=${FILE_SIZE}
size=999G
buffered=0
fadvise_hint=0
-group_reporting
#################################
# Test1
diff --git a/tests/ext4/302 b/tests/ext4/302
index 9307ab4..abca805 100644
--- a/tests/ext4/302
+++ b/tests/ext4/302
@@ -59,7 +59,6 @@ filesize=${FILE_SIZE}
size=999G
buffered=0
fadvise_hint=0
-group_reporting
##########################################
# Test2
diff --git a/tests/ext4/303 b/tests/ext4/303
index 84d8f7b..7051576 100644
--- a/tests/ext4/303
+++ b/tests/ext4/303
@@ -59,7 +59,6 @@ filesize=${FILE_SIZE}
size=999G
buffered=0
fadvise_hint=0
-group_reporting
#################################
# Test3
diff --git a/tests/ext4/304 b/tests/ext4/304
index 7b90f1d..5d15ecb 100644
--- a/tests/ext4/304
+++ b/tests/ext4/304
@@ -60,7 +60,6 @@ filesize=${FILE_SIZE}
size=999G
buffered=0
fadvise_hint=0
-group_reporting
#################################
# Test4
--
1.7.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] xfstests: dump _require_fio output to log
2013-04-15 11:09 [PATCH 1/2] xfstests: dump _require_fio output to log Dmitry Monakhov
2013-04-15 11:09 ` [PATCH 2/2] xfstests: fix fio's arguments Dmitry Monakhov
@ 2013-04-22 15:19 ` Rich Johnston
2013-04-22 15:30 ` Rich Johnston
2 siblings, 0 replies; 6+ messages in thread
From: Rich Johnston @ 2013-04-22 15:19 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: linux-fsdevel, linux-ext4, dchinner, xfs
Yes I agree this will help, looks good.
--Rich
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] xfstests: dump _require_fio output to log
2013-04-15 11:09 [PATCH 1/2] xfstests: dump _require_fio output to log Dmitry Monakhov
2013-04-15 11:09 ` [PATCH 2/2] xfstests: fix fio's arguments Dmitry Monakhov
2013-04-22 15:19 ` [PATCH 1/2] xfstests: dump _require_fio output to log Rich Johnston
@ 2013-04-22 15:30 ` Rich Johnston
2 siblings, 0 replies; 6+ messages in thread
From: Rich Johnston @ 2013-04-22 15:30 UTC (permalink / raw)
To: Dmitry Monakhov; +Cc: linux-fsdevel, linux-ext4, dchinner, xfs
On 04/15/2013 06:09 AM, Dmitry Monakhov wrote:
> diff --git a/tests/ext4/301 b/tests/ext4/301
> old mode 100644
> new mode 100755
>
Sorry I forgot to mention this change was unrelated to this patch.
tests/ext4/30? are changed to 755 in commit 'ca9fe94e'.
Thanks for this patch Dmitry, it has been committed.
--Rich
commit 6105b952f46cddf88029d14857cb2658cdab2d52
Author: Dmitry Monakhov <dmonakhov@openvz.org>
Date: Mon Apr 15 11:09:47 2013 +0000
xfstests: dump _require_fio output to log
This should help find incompatibility issues.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-04-22 15:31 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-15 11:09 [PATCH 1/2] xfstests: dump _require_fio output to log Dmitry Monakhov
2013-04-15 11:09 ` [PATCH 2/2] xfstests: fix fio's arguments Dmitry Monakhov
2013-04-22 15:21 ` Rich Johnston
2013-04-22 15:31 ` Rich Johnston
2013-04-22 15:19 ` [PATCH 1/2] xfstests: dump _require_fio output to log Rich Johnston
2013-04-22 15:30 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).