From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH 13/19] NFSD: Server implementation of MAC Labeling Date: Tue, 23 Apr 2013 15:40:43 -0400 Message-ID: <5176E3BB.4020508@RedHat.com> References: <1364939160-20874-1-git-send-email-SteveD@redhat.com> <1364939160-20874-14-git-send-email-SteveD@redhat.com> <20130410151953.GC24404@pad.fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Trond Myklebust , "David P. Quigley" , Linux NFS list , Linux FS devel list , Linux Security List , SELinux List To: "J. Bruce Fields" Return-path: In-Reply-To: <20130410151953.GC24404-spRCxval1Z7TsXDwO4sDpg@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On 10/04/13 11:19, J. Bruce Fields wrote: > On Tue, Apr 02, 2013 at 05:45:54PM -0400, Steve Dickson wrote: >> +__be32 nfsd4_set_nfs4_label(struct svc_rqst *rqstp, struct svc_fh *fhp, >> + struct nfs4_label *label) >> +{ >> + return -EOPNOTSUPP; > > Anything that returns a __be32 is expecting nfserr_something, not > -ERRNO. > I think it makes sense when label are not configured for this to return nfserr_notsupp which will then get turned into a -EOPNOTSUPP, agreed? steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html