From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [PATCH 3/4] mm: Activate !PageLRU pages on mark_page_accessed if page is on local pagevec Date: Wed, 15 May 2013 13:40:58 -0400 Message-ID: <5193C8AA.206@redhat.com> References: <1368440482-27909-1-git-send-email-mgorman@suse.de> <1368440482-27909-4-git-send-email-mgorman@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexey Lyahkov , Andrew Perepechko , Robin Dong , Theodore Tso , Andrew Morton , Hugh Dickins , Johannes Weiner , Bernd Schubert , David Howells , Trond Myklebust , Linux-fsdevel , Linux-ext4 , LKML , Linux-mm To: Mel Gorman Return-path: In-Reply-To: <1368440482-27909-4-git-send-email-mgorman@suse.de> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On 05/13/2013 06:21 AM, Mel Gorman wrote: > In this case a PageActive page is added to the inactivate list and later the > inactive/active stats will get skewed. While the PageActive checks in vmscan > could be removed and potentially dealt with, a skew in the statistics would > be very difficult to detect. Hence this patch deals just with the common case > where a page being marked accessed has just been added to the local pagevec. > > Signed-off-by: Mel Gorman After thinking about it some more, I suspect the possible issue I outlined before should not be an issue in practice. Acked-by: Rik van Riel -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org