* [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread
@ 2013-05-23 13:58 Namjae Jeon
2013-05-23 14:32 ` Jason Hrycay
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2013-05-23 13:58 UTC (permalink / raw)
To: jaegeuk.kim
Cc: Namjae Jeon, Amit Sahrawat, Namjae Jeon, linux-kernel,
linux-f2fs-devel, linux-fsdevel
From: Namjae Jeon <namjae.jeon@samsung.com>
when there is an error from kthread_run, then return proper error
rather than returning -ENOMEM.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
fs/f2fs/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 25b083c..03d5ba1 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -105,7 +105,7 @@ int start_gc_thread(struct f2fs_sb_info *sbi)
if (IS_ERR(gc_th->f2fs_gc_task)) {
kfree(gc_th);
sbi->gc_thread = NULL;
- return -ENOMEM;
+ return PTR_ERR(gc_th->f2fs_gc_task);
}
return 0;
}
--
1.7.9.5
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread
2013-05-23 13:58 [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread Namjae Jeon
@ 2013-05-23 14:32 ` Jason Hrycay
2013-05-23 22:37 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Jason Hrycay @ 2013-05-23 14:32 UTC (permalink / raw)
To: Namjae Jeon
Cc: Amit Sahrawat, Namjae Jeon, linux-kernel, linux-f2fs-devel,
jason.hrycay, linux-fsdevel
On 5/23/2013 8:58 AM, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> when there is an error from kthread_run, then return proper error
> rather than returning -ENOMEM.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
> ---
> fs/f2fs/gc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 25b083c..03d5ba1 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -105,7 +105,7 @@ int start_gc_thread(struct f2fs_sb_info *sbi)
> if (IS_ERR(gc_th->f2fs_gc_task)) {
> kfree(gc_th);
gc_th is free'd here, save off PTR_ERR result to avoid use-after-free?
> sbi->gc_thread = NULL;
> - return -ENOMEM;
> + return PTR_ERR(gc_th->f2fs_gc_task);
> }
> return 0;
> }
>
--
Jason Hrycay
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread
2013-05-23 14:32 ` Jason Hrycay
@ 2013-05-23 22:37 ` Namjae Jeon
0 siblings, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2013-05-23 22:37 UTC (permalink / raw)
To: Jason Hrycay
Cc: Amit Sahrawat, Namjae Jeon, linux-kernel, linux-f2fs-devel,
jason.hrycay, linux-fsdevel
2013/5/23, Jason Hrycay <jhrycay@gmail.com>:
> On 5/23/2013 8:58 AM, Namjae Jeon wrote:
>> From: Namjae Jeon <namjae.jeon@samsung.com>
>>
>> when there is an error from kthread_run, then return proper error
>> rather than returning -ENOMEM.
>>
>> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
>> Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
>> ---
>> fs/f2fs/gc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>> index 25b083c..03d5ba1 100644
>> --- a/fs/f2fs/gc.c
>> +++ b/fs/f2fs/gc.c
>> @@ -105,7 +105,7 @@ int start_gc_thread(struct f2fs_sb_info *sbi)
>> if (IS_ERR(gc_th->f2fs_gc_task)) {
>> kfree(gc_th);
>
> gc_th is free'd here, save off PTR_ERR result to avoid use-after-free?
Yes, I will change this patch.
Thanks for review :)
>
>> sbi->gc_thread = NULL;
>> - return -ENOMEM;
>> + return PTR_ERR(gc_th->f2fs_gc_task);
>> }
>> return 0;
>> }
>>
>
> --
> Jason Hrycay
>
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-23 22:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-23 13:58 [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread Namjae Jeon
2013-05-23 14:32 ` Jason Hrycay
2013-05-23 22:37 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).