linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Vesely <jvesely@redhat.com>
To: linux-scsi@vger.kernel.org, axboe@kernel.dk
Cc: James.Bottomley@hansenpartnership.com, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org,
	"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>,
	fujita.tomonori@lab.ntt.co.jp
Subject: Re: block: Allow merging of tail pages into the last segment
Date: Mon, 03 Jun 2013 15:30:36 +0200	[thread overview]
Message-ID: <51AC9A7C.90306@redhat.com> (raw)
In-Reply-To: <516D0ABF.1000700@redhat.com>

On 16/04/13 10:24, Jan Vesely wrote:
> On 28/03/13 10:38, Jan Vesely wrote:
>> Hi
>>
>> These patches modify __bio_add_page to accept pages that extent the last bio
>> segment. some drivers craft their buffers and rely on this behavior (see
>> message in patch 2 for details)
> 
> any comments on this version would be appreciated
> 
> thanks
> 
>>
>> jan
>>
>> v3: Use code from __blk_recalc_rq_segments to decide whether the page is
>>     mergeable, 
>>
>> v2: modify a comment
>>
>> Jan Vesely (2):
>>       block: factor out vector mergeable decision to a helper function
>>       block: modify __bio_add_page check to accept pages that don't start a new
>>
>>  block/blk-merge.c   | 52 +++++++++++++++++++++++++++++++---------------------
>>  fs/bio.c            | 29 ++++++++++++++++++-----------
>>  include/linux/bio.h |  3 +++
>>  3 files changed, 52 insertions(+), 32 deletions(-)
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
ping?


Jens, your input on v2 helped a lot, any comments on v3?

thanks
-- 
Jan Vesely <jvesely@redhat.com>

  reply	other threads:[~2013-06-03 13:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-28  9:38 block: Allow merging of tail pages into the last segment Jan Vesely
2013-03-28  9:38 ` [PATCH v3 1/2] block: factor out vector mergeable decision to a helper function Jan Vesely
2013-03-28  9:38 ` [PATCH v3 2/2] block: modify __bio_add_page check to accept pages that don't start a new segment Jan Vesely
2013-04-16  8:24 ` block: Allow merging of tail pages into the last segment Jan Vesely
2013-06-03 13:30   ` Jan Vesely [this message]
2013-06-21 15:31     ` Jan Vesely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AC9A7C.90306@redhat.com \
    --to=jvesely@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Kai.Makisara@kolumbus.fi \
    --cc=axboe@kernel.dk \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).