From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v4 04/12] auto-fs: rename d_count field of dentry to d_refcount Date: Thu, 04 Jul 2013 10:47:42 -0400 Message-ID: <51D58B0E.8090206@hp.com> References: <1372908808-33304-1-git-send-email-Waiman.Long@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Viro , Jeff Layton , Miklos Szeredi , Ingo Molnar , Thomas Gleixner , Ian Kent , autofs mailing list , linux-fsdevel , Linux Kernel Mailing List , Peter Zijlstra , Steven Rostedt , Benjamin Herrenschmidt , Andi Kleen , "Chandramouleeswaran, Aswin" , "Norton, Scott J" To: Linus Torvalds Return-path: In-Reply-To: Sender: autofs-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 07/03/2013 11:50 PM, Linus Torvalds wrote: > On Wed, Jul 3, 2013 at 8:33 PM, Waiman Long wrote: >> Because of the d_count name change made in dcache.h, all references >> to d_count have to be changed to d_refcount. There is no change in >> logic and everything should just work. > These filesystem patches need to be just joined into the same patch > that does the d_count -> d_refcount change. > > Otherwise the kernel won't build in lots of configurations for some > commits, which makes things like bisecting much more painful than it > should be. > > So we can't do piece-meal changes that break the build for parts of the tree. > > Linus I could change patch 3 so that I keep the d_count name, but #define d_refcount to d_count. In that way, I can do piece-meal changes without breaking the build. Alternatively, I could collapse patches 3-11 into a single big patch which will be harder to review. Regards, Longman