From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v5 00/12] Lockless update of reference count protected by spinlock Date: Fri, 05 Jul 2013 11:31:37 -0400 Message-ID: <51D6E6D9.4010201@hp.com> References: <1373035656-40600-1-git-send-email-Waiman.Long@hp.com> <20130705150224.GS4165@ZenIV.linux.org.uk> <51D6E646.6020703@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jeff Layton , Miklos Szeredi , Ingo Molnar , Thomas Gleixner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Steven Rostedt , Linus Torvalds , Benjamin Herrenschmidt , Andi Kleen , "Chandramouleeswaran, Aswin" , "Norton, Scott J" To: Al Viro Return-path: In-Reply-To: <51D6E646.6020703@hp.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 07/05/2013 11:29 AM, Waiman Long wrote: > On 07/05/2013 11:02 AM, Al Viro wrote: >> On Fri, Jul 05, 2013 at 10:47:33AM -0400, Waiman Long wrote: >>> v4->v5: >>> - Add a d_count() helper for readonly access of reference count and >>> change all references to d_count outside of dcache.c, dcache.h >>> and namei.c to use d_count(). >> Sigh... You are breaking bisectability again. This helper should >> be introduced *first*, along with conversion to it. Then you can >> do the rest on top of that. >> >> I've just pushed such commit into vfs.git#for-linus; please, do the rest >> on top of it. And keep it bisectable, i.e. so that at any intermediate >> point the tree would build and work. > > I am sorry. I didn't change anything in the dentry structure in patch > 3. So putting patches 4-11 on top of it won't break the build. I explicitly applied the patches one at a time to make sure that there was no broken build. Regards, Longman