From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zach Levis <zml@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 2/3] fs/binfmts: Better handling of binfmt loops
Date: Fri, 02 Aug 2013 15:49:13 -0700
Message-ID: <51FC3769.2030302@linux.vnet.ibm.com>
References: <1374766845-13565-1-git-send-email-zml@linux.vnet.ibm.com> <1375481535-20034-3-git-send-email-zml@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: akpm@linux-foundation.org, oleg@redhat.com,
	viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, dan.carpenter@oracle.com,
	Zach Levis <zach@zachsthings.com>
To: Zach Levis <zml@linux.vnet.ibm.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from e8.ny.us.ibm.com ([32.97.182.138]:34379 "EHLO e8.ny.us.ibm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752273Ab3HBWtT (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 2 Aug 2013 18:49:19 -0400
Received: from /spool/local
	by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <linux-fsdevel@vger.kernel.org> from <zml@linux.vnet.ibm.com>;
	Fri, 2 Aug 2013 23:49:18 +0100
In-Reply-To: <1375481535-20034-3-git-send-email-zml@linux.vnet.ibm.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 08/02/2013 03:12 PM, Zach Levis wrote:

> +		if (retval == -ELOOP && bprm->recursion_depth == 0) { /* cur, previous */
> +			pr_err("Too much recursion with binfmts (0:%s, -1:%s) in file %s, skipping (base %s).\n",
> +					bprm->previous_binfmts[0]->name,
> +					bprm->previous_binfmts[1]->name,
> +					bprm->filename,
> +					fmt->name);
> +
> +			/* Put argv back in its place */
> +			bprm->p = bprm->p_no_argv;
> +
> +			bprm->argc = count(*(bprm->argv_orig), MAX_ARG_STRINGS);
> +			retval = copy_strings(bprm->argc, *(bprm->argv_orig), bprm);
> +			if (retval < 0)
> +				return retval;
> +
> +			retval = -ENOEXEC;
> +			continue;
> +		}
>   	}
>   	read_unlock(&binfmt_lock);
>

NEVERMIND, I messed up the order here so this doesn't work! v3 coming up 
without the stupid.