From: Martin Wilck <mwilck@suse.com>
To: Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"agk@redhat.com" <agk@redhat.com>, "hare@suse.de" <hare@suse.de>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"yuchao0@huawei.com" <yuchao0@huawei.com>,
"ghe@suse.com" <ghe@suse.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"tchvatal@suse.com" <tchvatal@suse.com>
Subject: Re: [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup
Date: Fri, 15 Jun 2018 13:07:16 +0200 [thread overview]
Message-ID: <51d72b3bcc384edf3f90892667d1707e9c1036f8.camel@suse.com> (raw)
In-Reply-To: <20180614134235.GA21624@infradead.org>
On Thu, 2018-06-14 at 06:42 -0700, Christoph Hellwig wrote:
> On Thu, Jun 14, 2018 at 01:39:50PM +0000, Bart Van Assche wrote:
> > On Thu, 2018-06-14 at 10:01 +0000, Damien Le Moal wrote:
> > > Applied. Thanks Luis !
> >
> > Hello Damien,
> >
> > Can this still be undone? I agree with Mike that it's wrong to
> > invoke
> > "/sbin/dmsetup create ... zoned ..." from a udev rule.
>
> Yes. We'll really need to verfify the device has dm-zoned metadata
> first. Preferably including a uuid for stable device naming.
libblkid would be the central hub for metadata discovery, so perhaps a
patch should be made to make libblkid dm-zoned-aware.
Anyway, as Damien explained, dmzoned bails out if it doesn't find
matching meta data, so AFAICS, little harm is done by calling it for a
SMR device in host-managed mode. I fail to get the point why this would
be wrong in general - what's the difference to e.g. calling "mdadm -I"?
Regards
Martin
--
Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-06-15 11:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 0:11 [PATCH] dm-zoned-tools: add zoned disk udev rules for scheduler / dmsetup Luis R. Rodriguez
2018-06-14 10:01 ` Damien Le Moal
2018-06-14 13:39 ` Bart Van Assche
2018-06-14 13:42 ` Christoph Hellwig
2018-06-15 11:07 ` Martin Wilck [this message]
2018-06-14 12:38 ` Mike Snitzer
2018-06-14 16:23 ` Bart Van Assche
2018-06-14 17:37 ` Luis R. Rodriguez
2018-06-14 17:46 ` Luis R. Rodriguez
2018-06-14 17:58 ` Mike Snitzer
2018-06-15 9:59 ` Damien Le Moal
2018-06-15 14:50 ` Mike Snitzer
2018-06-15 9:00 ` Damien Le Moal
2018-06-14 16:19 ` [PATCH] " Bart Van Assche
2018-06-14 17:44 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51d72b3bcc384edf3f90892667d1707e9c1036f8.camel@suse.com \
--to=mwilck@suse.com \
--cc=Bart.VanAssche@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=ghe@suse.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=tchvatal@suse.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).