From: Dave Hansen <dave.hansen@intel.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Dave Chinner <david@fromorbit.com>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Dave Chinner <dchinner@redhat.com>,
Andi Kleen <ak@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Avoid useless inodes and dentries reclamation
Date: Thu, 29 Aug 2013 11:36:10 -0700 [thread overview]
Message-ID: <521F949A.2020908@intel.com> (raw)
In-Reply-To: <1377799676.3625.69.camel@schen9-DESK>
The new shrinker infrastructure in mmotm looks like it will make this
problem worse.
old code:
shrink_slab()
for_each_shrinker {
do_shrinker_shrink(); // one per batch
prune_super()
grab_super_passive()
}
}
Which means we've got at _most_ one grab_super_passive() per batch. The
new code is something like this:
shrink_slab()
{
list_for_each_entry(shrinker, &shrinker_list, list) {
for_each_node_mask(... shrinkctl->nodes_to_scan) {
shrink_slab_node()
}
}
}
shrink_slab_node()
{
max_pass = shrinker->count_objects(shrinker, shrinkctl);
// ^^ does grab_super_passive()
...
while (total_scan >= batch_size) {
ret = shrinker->scan_objects(shrinker, shrinkctl);
// ^^ does grab_super_passive()
}
}
We've got an extra grab_super_passive()s in the case where we are
actually doing a scan, plus we've got the extra for_each_node_mask()
loop. That means even more lock acquisitions in the multi-node NUMA
case, which is exactly where we want to get rid of global lock acquisitions.
next prev parent reply other threads:[~2013-08-29 18:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 21:52 [PATCH] Avoid useless inodes and dentries reclamation Tim Chen
2013-08-28 21:19 ` Kirill A. Shutemov
2013-08-28 22:54 ` Tim Chen
2013-08-29 11:07 ` Dave Chinner
2013-08-29 18:07 ` Tim Chen
2013-08-29 18:36 ` Dave Hansen [this message]
2013-08-30 1:56 ` Dave Chinner
2013-08-30 1:40 ` Dave Chinner
2013-08-30 16:21 ` Tim Chen
2013-08-31 9:00 ` Dave Chinner
2013-09-03 18:38 ` Tim Chen
2013-09-06 0:55 ` Dave Chinner
2013-09-06 18:26 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F949A.2020908@intel.com \
--to=dave.hansen@intel.com \
--cc=ak@linux.intel.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).