From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marco Stornelli <marco.stornelli@gmail.com>
Subject: Re: [PATCH 12/19] pramfs: symlink operations
Date: Sat, 07 Sep 2013 18:09:27 +0200
Message-ID: <522B4FB7.9050107@gmail.com>
References: <522AE3DB.7000209@gmail.com> <20130907144118.GA13318@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Vladimir Davydov <vdavydov@parallels.com>,
	linux-kernel@vger.kernel.org,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20130907144118.GA13318@ZenIV.linux.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Il 07/09/2013 16:41, Al Viro ha scritto:
> On Sat, Sep 07, 2013 at 10:29:15AM +0200, Marco Stornelli wrote:
>> +static int pram_readlink(struct dentry *dentry, char __user *buffer, int buflen)
>> +{
>> +	struct inode *inode = dentry->d_inode;
>> +	struct super_block *sb = inode->i_sb;
>> +	u64 block;
>> +	char *blockp;
>> +
>> +	block = pram_find_data_block(inode, 0);
>> +	blockp = pram_get_block(sb, block);
>> +	return vfs_readlink(dentry, buffer, buflen, blockp);
>> +}
>
>> +static void *pram_follow_link(struct dentry *dentry, struct nameidata *nd)
>> +{
>> +	struct inode *inode = dentry->d_inode;
>> +	struct super_block *sb = inode->i_sb;
>> +	off_t block;
>> +	int status;
>> +	char *blockp;
>> +
>> +	block = pram_find_data_block(inode, 0);
>> +	blockp = pram_get_block(sb, block);
>> +	status = vfs_follow_link(nd, blockp);
>> +	return ERR_PTR(status);
>> +}
>
> Just nd_set_link(nd, blockp) instead of that vfs_follow_link() and be
> done with that; that way you can use generic_readlink() instead of
> pram_readlink() *and* get lower stack footprint on traversing them.
>
>

Yep, you're right (as usual :))

Marco