From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH 1/2] seqlock: Add a new blocking reader type Date: Wed, 11 Sep 2013 14:34:47 -0400 Message-ID: <5230B7C7.20503@hp.com> References: <1378909707-3347-1-git-send-email-Waiman.Long@hp.com> <20130911145536.GJ13318@ZenIV.linux.org.uk> <52309B5F.70406@hp.com> <20130911172624.GK13318@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Thomas Gleixner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Chandramouleeswaran, Aswin" , "Norton, Scott J" To: Al Viro Return-path: In-Reply-To: <20130911172624.GK13318@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 09/11/2013 01:26 PM, Al Viro wrote: > On Wed, Sep 11, 2013 at 12:33:35PM -0400, Waiman Long wrote: > >>> Folks, any suggestions on better names? The semantics we are getting is >> I will welcome any better name suggestion and will incorporate that >> in the patch. > FWIW, the suggestions I've seen so far had been > > seq_exreadlock() [ex for exclusive] > seq_exclreadlock() [ditto, and IMO fails the "easily read over the phone" > test - /sekv-excre...ARRGH/] > seq_prot_readlock() [prot for protected, as in DLM protected read] Following the naming convention in seqlock.h that all functions begin with read_ or write_, is read_seqexcl_lock() look OK to you? -Longman