linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Steve French" <smfrench@gmail.com>
To: linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org
Cc: matt@opcode-solutions.com
Subject: Re: [PATCH] CIFS should honour umask
Date: Thu, 7 Jun 2007 12:01:57 -0500	[thread overview]
Message-ID: <524f69650706071001q30a818eepfef98010258b14f7@mail.gmail.com> (raw)
In-Reply-To: <4667AE70.7090800@opcode-solutions.com>

For the non-unix case (e.g. Windows servers) the mode will be taken
from the default specified on the mount. I am not sure if we also
should add code to also honor umask in that case.

I am not sure how common it is to change umask to different values in
different processes which would access the same mount.

Thoughts?

> Steve French wrote:
> > Thanks - it looks almost right but you missed mknod case and your
> > patch had some whitespace/formatting problems.
> >
> > Could you try the following and make sure it works for you?  If so
> > will merge.

       reply	other threads:[~2007-06-07 17:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <466705F5.9000702@opcode-solutions.com>
     [not found] ` <524f69650706061723i3e065d0y83739e50d986a06f@mail.gmail.com>
     [not found]   ` <4667AE70.7090800@opcode-solutions.com>
2007-06-07 17:01     ` Steve French [this message]
2007-06-07 17:42       ` [PATCH] CIFS should honour umask Matt Keenan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524f69650706071001q30a818eepfef98010258b14f7@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=linux-cifs-client@lists.samba.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=matt@opcode-solutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).