* Re: [PATCH] CIFS should honour umask
[not found] ` <4667AE70.7090800@opcode-solutions.com>
@ 2007-06-07 17:01 ` Steve French
2007-06-07 17:42 ` Matt Keenan
0 siblings, 1 reply; 2+ messages in thread
From: Steve French @ 2007-06-07 17:01 UTC (permalink / raw)
To: linux-fsdevel, linux-cifs-client; +Cc: matt
For the non-unix case (e.g. Windows servers) the mode will be taken
from the default specified on the mount. I am not sure if we also
should add code to also honor umask in that case.
I am not sure how common it is to change umask to different values in
different processes which would access the same mount.
Thoughts?
> Steve French wrote:
> > Thanks - it looks almost right but you missed mknod case and your
> > patch had some whitespace/formatting problems.
> >
> > Could you try the following and make sure it works for you? If so
> > will merge.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] CIFS should honour umask
2007-06-07 17:01 ` [PATCH] CIFS should honour umask Steve French
@ 2007-06-07 17:42 ` Matt Keenan
0 siblings, 0 replies; 2+ messages in thread
From: Matt Keenan @ 2007-06-07 17:42 UTC (permalink / raw)
To: Steve French; +Cc: linux-fsdevel, linux-cifs-client
Steve French wrote:
> For the non-unix case (e.g. Windows servers) the mode will be taken
> from the default specified on the mount. I am not sure if we also
> should add code to also honor umask in that case.
>
I don't think it would be necessary to add code for the windows case, we
should just rely on windows semantics (with acl if supplied) for pure
windows mounts.
> I am not sure how common it is to change umask to different values in
> different processes which would access the same mount.
>
I think if we are going to use umask we should use it the way it is used
in Unix, i.e. tagged to the process. I realise that in some
circumstances that having a mount wide umask would be handy, however if
we are going to apply unix style semantics we should stick to the unix
style process bound umask; i.e. the method of least suprise.
Matt
--
Matt Keenan
OpCode Solutions
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-07 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <466705F5.9000702@opcode-solutions.com>
[not found] ` <524f69650706061723i3e065d0y83739e50d986a06f@mail.gmail.com>
[not found] ` <4667AE70.7090800@opcode-solutions.com>
2007-06-07 17:01 ` [PATCH] CIFS should honour umask Steve French
2007-06-07 17:42 ` Matt Keenan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).