From: "Steve French" <smfrench@gmail.com>
To: "Andrew Morton" <akpm@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: qstr abuse in git-cifs
Date: Tue, 6 Nov 2007 09:28:30 -0600 [thread overview]
Message-ID: <524f69650711060728k77b57e1fh36e89ddbe46bb9b2@mail.gmail.com> (raw)
> I suspect that bad things are happening in there
I doubt that it is too bad since various filesystems (including JFS
and CIFS) have always written over qstr->name in these dentries in
order to better handle case insensitive compares. Other than trying
to remove the compiler warning recently (mainline throws the same
warning), I didn't see what changed other than now displaying a
warning. I agree that it looks strange, but I also don't see a
trivial way to change it. Any ideas on how to prevent the case of an
existing negative dentry from taking precedence? Creating more
dentries for these duplicates would seem like a worse idea.
> fs/cifs/dir.c: In function 'cifs_ci_compare':
> fs/cifs/dir.c:596: warning: passing argument 1 of '__constant_memcpy' discards qualifiers from pointer target type
> fs/cifs/dir.c:596: warning: passing argument 1 of '__memcpy' discards qualifiers from pointer target type
--
Thanks,
Steve
next reply other threads:[~2007-11-06 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-06 15:28 Steve French [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-06 7:28 qstr abuse in git-cifs Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524f69650711060728k77b57e1fh36e89ddbe46bb9b2@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).