From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: qstr abuse in git-cifs Date: Tue, 6 Nov 2007 09:28:30 -0600 Message-ID: <524f69650711060728k77b57e1fh36e89ddbe46bb9b2@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: "Andrew Morton" , linux-fsdevel Return-path: Received: from py-out-1112.google.com ([64.233.166.176]:37796 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbXKFP2c (ORCPT ); Tue, 6 Nov 2007 10:28:32 -0500 Received: by py-out-1112.google.com with SMTP id u77so3780804pyb for ; Tue, 06 Nov 2007 07:28:31 -0800 (PST) Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > I suspect that bad things are happening in there I doubt that it is too bad since various filesystems (including JFS and CIFS) have always written over qstr->name in these dentries in order to better handle case insensitive compares. Other than trying to remove the compiler warning recently (mainline throws the same warning), I didn't see what changed other than now displaying a warning. I agree that it looks strange, but I also don't see a trivial way to change it. Any ideas on how to prevent the case of an existing negative dentry from taking precedence? Creating more dentries for these duplicates would seem like a worse idea. > fs/cifs/dir.c: In function 'cifs_ci_compare': > fs/cifs/dir.c:596: warning: passing argument 1 of '__constant_memcpy' discards qualifiers from pointer target type > fs/cifs/dir.c:596: warning: passing argument 1 of '__memcpy' discards qualifiers from pointer target type -- Thanks, Steve