From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: remove some of cifs hard to read ifdefs Date: Tue, 12 Feb 2008 15:25:49 -0600 Message-ID: <524f69650802121325k1d9e88c4ndcf41962923dd337@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: linux-fsdevel Return-path: Received: from ug-out-1314.google.com ([66.249.92.172]:44776 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734AbYBLVZv (ORCPT ); Tue, 12 Feb 2008 16:25:51 -0500 Received: by ug-out-1314.google.com with SMTP id z38so613343ugc.16 for ; Tue, 12 Feb 2008 13:25:50 -0800 (PST) Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Feb 7, 2008 12:25 PM, Christoph Hellwig wrote: > and while I'm at it a lot of the non-DFS additions to cifs aren't quite > up to standards for kernel code either, lots of useless braces, wierd > coding style and ifdef mania. The useless braces should be removed now. The "ifdef mania" should be cut by about a quarter by the following patch (following up on the patch idea posted late last week): http://git.kernel.org/?p=linux/kernel/git/sfrench/cifs-2.6.git;a=commitdiff;h=90c81e0b0eda214196cbe4340facbce8cc797ee7 -- Thanks, Steve