From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points Date: Mon, 18 Feb 2008 22:51:41 -0600 Message-ID: <524f69650802182051k479eae58yd6ef644e3c65282@mail.gmail.com> References: <1199988975.7483.3.camel@gn2.draper.com> <524f69650801101228o3639363cp4c9710d747b71ead@mail.gmail.com> <20080111090749.GA14910@infradead.org> <524f69650801110805y56cdbe4nf7587e396b70f32c@mail.gmail.com> <20080113202144.GB24573@infradead.org> <47B5BFCF.60304@mail.ru> <20080215170552.GA27584@infradead.org> <524f69650802151302h4e631a74pe382ca932cc85c7@mail.gmail.com> <20080215221158.GA15021@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Q (Igor Mammedov)" , linux-fsdevel , linux-cifs-client@lists.samba.org, "Shirish Pargaonkar" To: "Christoph Hellwig" Return-path: Received: from fk-out-0910.google.com ([209.85.128.188]:19201 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753434AbYBSEvn (ORCPT ); Mon, 18 Feb 2008 23:51:43 -0500 Received: by fk-out-0910.google.com with SMTP id z23so2196428fkz.5 for ; Mon, 18 Feb 2008 20:51:42 -0800 (PST) In-Reply-To: <20080215221158.GA15021@infradead.org> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The patch looks fine - but since it does not set obj_type any more - I want to think about it a little more since it may be useful coming back from the open path (although the mode is probably good enough). jra added support to Samba for a new POSIX open/create/mkdir request (which we only use for mkdir at the moment) - using this call for open (when the server indicates support for it as Samba does) would cut the number of roundtrips to the server on these calls as it does now for mkdir. On Feb 15, 2008 4:11 PM, Christoph Hellwig wrote: > If you like these kind of consolidation patches here's another one: > > > -- Thanks, Steve