From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: [linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points Date: Sat, 8 Mar 2008 21:49:35 -0600 Message-ID: <524f69650803081949g23e4e415o5494df436efc64a0@mail.gmail.com> References: <1199988975.7483.3.camel@gn2.draper.com> <524f69650801101228o3639363cp4c9710d747b71ead@mail.gmail.com> <20080111090749.GA14910@infradead.org> <524f69650801110805y56cdbe4nf7587e396b70f32c@mail.gmail.com> <20080113202144.GB24573@infradead.org> <47B5BFCF.60304@mail.ru> <47CD42DA.3070809@mail.ru> <20080308184127.GA1461@infradead.org> <71bff3710803081421l7f248614t44762d00bbf17af@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Christoph Hellwig" , linux-fsdevel , linux-cifs-client@lists.samba.org To: "Q (Igor Mammedov)" Return-path: Received: from fg-out-1718.google.com ([72.14.220.154]:60692 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbYCIDth (ORCPT ); Sat, 8 Mar 2008 22:49:37 -0500 Received: by fg-out-1718.google.com with SMTP id e21so1330275fga.17 for ; Sat, 08 Mar 2008 19:49:35 -0800 (PST) In-Reply-To: <71bff3710803081421l7f248614t44762d00bbf17af@mail.gmail.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Merged but with two corrections: initialized full_path to null on line 376 since it could be used unitialized in one path later in cifs_get_inode_info and also fixed a spelling error. Thanks. On Sat, Mar 8, 2008 at 4:21 PM, Q (Igor Mammedov) wrote: > Thanks for your comments. Fixed patch is attached. > > On Sat, Mar 8, 2008 at 9:41 PM, Christoph Hellwig wrote: > > > > On Tue, Mar 04, 2008 at 03:38:50PM +0300, Q (Igor Mammedov) wrote: > > > Hi Steve, > > > > > > Looked through inode.c code again and rewrote/simplified patch5 > > > See attachment for it. > > > > Thanks, this looks much better. A few (mostly cosmetic) comments: -- Thanks, Steve