linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Steve French" <smfrench@gmail.com>
To: "Q (Igor Mammedov)" <qwerty0987654321@mail.ru>,
	"Igor Mammedov" <niallain@gmail.com>
Cc: "Jeremy Allison" <jra@samba.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: DFS patch series
Date: Fri, 25 Apr 2008 19:34:15 -0500	[thread overview]
Message-ID: <524f69650804251734y48a1ccf8g899b4bc3a5a21262@mail.gmail.com> (raw)

I merged the first patch in your remaining cifs dfs series patch
0001-Adds-to-dns_resolver-checking-if-the-server-name-is.patch into
the cifs tree, but isn't this section of the 2nd patch of three ie
0002-fixed-compatibility-issue-with-samba-a-refferal-req.patch
incorrect? It is converting the slashes in the whole path (not in the
UNC prefix) - so escape sequences in real posix directory and file
names will be converted to separators.  This seems wrong.  We should
be converting just the treename part here.

@@ -243,6 +240,12 @@ static char
*build_full_dfs_path_from_dentry(struct dentry *dentry)
                strncpy(tmp_path, cifs_sb->tcon->treeName, l_max_len);
                strcat(tmp_path, search_path);
                tmp_path[l_max_len-1] = 0;
+               if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS)
+                       for (i = 0; i < l_max_len; i++) {
+                               if (tmp_path[i] == '\\')
+                                       tmp_path[i] = '/';
+                       }
+
                full_path = tmp_path;
                kfree(search_path);
        } else {


-- 
Thanks,

Steve

             reply	other threads:[~2008-04-26  0:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26  0:34 Steve French [this message]
2008-04-26 17:41 ` DFS patch series - fixed Igor Mammedov
2008-04-28  3:40   ` Steve French
2008-04-28  8:05     ` Igor Mammedov
2008-04-28 23:06       ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524f69650804251734y48a1ccf8g899b4bc3a5a21262@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=jra@samba.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=niallain@gmail.com \
    --cc=qwerty0987654321@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).