From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: DFS patch series Date: Fri, 25 Apr 2008 19:34:15 -0500 Message-ID: <524f69650804251734y48a1ccf8g899b4bc3a5a21262@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Jeremy Allison" , linux-fsdevel To: "Q (Igor Mammedov)" , "Igor Mammedov" Return-path: Received: from fg-out-1718.google.com ([72.14.220.154]:4343 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754875AbYDZAeR (ORCPT ); Fri, 25 Apr 2008 20:34:17 -0400 Received: by fg-out-1718.google.com with SMTP id l27so3806124fgb.17 for ; Fri, 25 Apr 2008 17:34:15 -0700 (PDT) Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: I merged the first patch in your remaining cifs dfs series patch 0001-Adds-to-dns_resolver-checking-if-the-server-name-is.patch into the cifs tree, but isn't this section of the 2nd patch of three ie 0002-fixed-compatibility-issue-with-samba-a-refferal-req.patch incorrect? It is converting the slashes in the whole path (not in the UNC prefix) - so escape sequences in real posix directory and file names will be converted to separators. This seems wrong. We should be converting just the treename part here. @@ -243,6 +240,12 @@ static char *build_full_dfs_path_from_dentry(struct dentry *dentry) strncpy(tmp_path, cifs_sb->tcon->treeName, l_max_len); strcat(tmp_path, search_path); tmp_path[l_max_len-1] = 0; + if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_POSIX_PATHS) + for (i = 0; i < l_max_len; i++) { + if (tmp_path[i] == '\\') + tmp_path[i] = '/'; + } + full_path = tmp_path; kfree(search_path); } else { -- Thanks, Steve