linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Steve French" <smfrench@gmail.com>
To: "Igor Mammedov" <niallain@gmail.com>
Cc: "Q (Igor Mammedov)" <qwerty0987654321@mail.ru>,
	"Jeremy Allison" <jra@samba.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: DFS patch series - fixed
Date: Sun, 27 Apr 2008 22:40:15 -0500	[thread overview]
Message-ID: <524f69650804272040w580af8eby5d2989f6b2b2e06b@mail.gmail.com> (raw)
In-Reply-To: <48136945.5020004@gmail.com>

Is your change to cifs_get_share_name code intentional?  You allow the
\\server\share\path string to not be terminated by a path (ie be
\\server\share)

On Sat, Apr 26, 2008 at 12:41 PM, Igor Mammedov <niallain@gmail.com> wrote:
> Steve French wrote:
>  > I merged the first patch in your remaining cifs dfs series patch
>  > 0001-Adds-to-dns_resolver-checking-if-the-server-name-is.patch into
>  > the cifs tree, but isn't this section of the 2nd patch of three ie
>  > 0002-fixed-compatibility-issue-with-samba-a-refferal-req.patch
>  > incorrect? It is converting the slashes in the whole path (not in the
>  > UNC prefix) - so escape sequences in real posix directory and file
>  > names will be converted to separators.  This seems wrong.  We should
>  > be converting just the treename part here.
>  >
>  > ...
>
>  Fixed, now it converts only treeName part of the path:
>  0003-fixed-compatibility-issue-with-samba-a-refferal-requ.patch
>
>  In my test setup it works.
>
>  --
>
>  Best regards,
>
>  -------------------------
>  Igor Mammedov,
>  niallain "at" gmail.com
>
>
>
>
>



-- 
Thanks,

Steve

  reply	other threads:[~2008-04-28  3:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26  0:34 DFS patch series Steve French
2008-04-26 17:41 ` DFS patch series - fixed Igor Mammedov
2008-04-28  3:40   ` Steve French [this message]
2008-04-28  8:05     ` Igor Mammedov
2008-04-28 23:06       ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524f69650804272040w580af8eby5d2989f6b2b2e06b@mail.gmail.com \
    --to=smfrench@gmail.com \
    --cc=jra@samba.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=niallain@gmail.com \
    --cc=qwerty0987654321@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).