From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: DFS patch series - fixed Date: Sun, 27 Apr 2008 22:40:15 -0500 Message-ID: <524f69650804272040w580af8eby5d2989f6b2b2e06b@mail.gmail.com> References: <524f69650804251734y48a1ccf8g899b4bc3a5a21262@mail.gmail.com> <48136945.5020004@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Q (Igor Mammedov)" , "Jeremy Allison" , linux-fsdevel To: "Igor Mammedov" Return-path: Received: from fg-out-1718.google.com ([72.14.220.159]:59764 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762229AbYD1DkS (ORCPT ); Sun, 27 Apr 2008 23:40:18 -0400 Received: by fg-out-1718.google.com with SMTP id l27so4762140fgb.17 for ; Sun, 27 Apr 2008 20:40:16 -0700 (PDT) In-Reply-To: <48136945.5020004@gmail.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Is your change to cifs_get_share_name code intentional? You allow the \\server\share\path string to not be terminated by a path (ie be \\server\share) On Sat, Apr 26, 2008 at 12:41 PM, Igor Mammedov wrote: > Steve French wrote: > > I merged the first patch in your remaining cifs dfs series patch > > 0001-Adds-to-dns_resolver-checking-if-the-server-name-is.patch into > > the cifs tree, but isn't this section of the 2nd patch of three ie > > 0002-fixed-compatibility-issue-with-samba-a-refferal-req.patch > > incorrect? It is converting the slashes in the whole path (not in the > > UNC prefix) - so escape sequences in real posix directory and file > > names will be converted to separators. This seems wrong. We should > > be converting just the treename part here. > > > > ... > > Fixed, now it converts only treeName part of the path: > 0003-fixed-compatibility-issue-with-samba-a-refferal-requ.patch > > In my test setup it works. > > -- > > Best regards, > > ------------------------- > Igor Mammedov, > niallain "at" gmail.com > > > > > -- Thanks, Steve