From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: DFS patch series - fixed Date: Mon, 28 Apr 2008 18:06:28 -0500 Message-ID: <524f69650804281606pbd7b34cn82b253229c022b4b@mail.gmail.com> References: <524f69650804251734y48a1ccf8g899b4bc3a5a21262@mail.gmail.com> <48136945.5020004@gmail.com> <524f69650804272040w580af8eby5d2989f6b2b2e06b@mail.gmail.com> <48158559.70904@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Q (Igor Mammedov)" , "Jeremy Allison" , linux-fsdevel To: "Igor Mammedov" Return-path: Received: from nf-out-0910.google.com ([64.233.182.188]:53867 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968041AbYD1XGa (ORCPT ); Mon, 28 Apr 2008 19:06:30 -0400 Received: by nf-out-0910.google.com with SMTP id g13so2029470nfb.21 for ; Mon, 28 Apr 2008 16:06:29 -0700 (PDT) In-Reply-To: <48158559.70904@gmail.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: merged On Mon, Apr 28, 2008 at 3:05 AM, Igor Mammedov wrote: > Steve French wrote: > > Is your change to cifs_get_share_name code intentional? You allow the > > \\server\share\path string to not be terminated by a path (ie be > > \\server\share) > > Yes, there was error in previous version, I've stumbled upon it while mounting > referrals without a path part in it. (the function still do what it did but > now it correctly handles ref unc that consists only from treeName) > > cifs_get_share_name should return unc from ref UNC as if it was handled > by mount.cifs helper (i.e. cut off the path part from unc and leave only > a treeName, the path part would be specified as prefixpath option later > in compose_mount_options). > > > > > On Sat, Apr 26, 2008 at 12:41 PM, Igor Mammedov wrote: > >> Steve French wrote: > >> > I merged the first patch in your remaining cifs dfs series patch > >> > 0001-Adds-to-dns_resolver-checking-if-the-server-name-is.patch into > >> > the cifs tree, but isn't this section of the 2nd patch of three ie > >> > 0002-fixed-compatibility-issue-with-samba-a-refferal-req.patch > >> > incorrect? It is converting the slashes in the whole path (not in the > >> > UNC prefix) - so escape sequences in real posix directory and file > >> > names will be converted to separators. This seems wrong. We should > >> > be converting just the treename part here. > >> > > >> > ... > >> > >> Fixed, now it converts only treeName part of the path: > >> 0003-fixed-compatibility-issue-with-samba-a-refferal-requ.patch > >> > >> In my test setup it works. > >> > >> -- > >> > >> Best regards, > >> > >> ------------------------- > >> Igor Mammedov, > >> niallain "at" gmail.com > >> > >> > >> > >> > >> > > > > > > > > > -- > > Best regards, > > ------------------------- > Igor Mammedov, > niallain "at" gmail.com > > > > > -- Thanks, Steve