From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: dfs path construction fix - send dfs paths on all path based operations on share in dfs Date: Thu, 15 May 2008 01:22:28 -0500 Message-ID: <524f69650805142322kb559d01x3c954ce33fd196a0@mail.gmail.com> References: <524f69650805131545id9be81et97549c74ecd0e7c8@mail.gmail.com> <482AD201.5010200@gmail.com> <524f69650805141150u3975b19al9b33f76378b28be3@mail.gmail.com> <524f69650805141853t2ca20b25hd8fa79d698445a62@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel , linux-cifs-client@samba.org To: "Igor Mammedov" Return-path: Received: from fg-out-1718.google.com ([72.14.220.158]:29525 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbYEOGWa (ORCPT ); Thu, 15 May 2008 02:22:30 -0400 Received: by fg-out-1718.google.com with SMTP id 19so231693fgg.17 for ; Wed, 14 May 2008 23:22:28 -0700 (PDT) In-Reply-To: <524f69650805141853t2ca20b25hd8fa79d698445a62@mail.gmail.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: just checked in some of the GetDFSRefer cleanup into cifs-2.6. (with minor style changes) Missing still: 1) faking up inode after initial PATH_NOT_COVERED 2) cleanup of the code which parses the SMB response in GetDFSRefer function in fs/cifs/cifssmb.c On Wed, May 14, 2008 at 8:53 PM, Steve French wrote: > I found the december version - and checked in part. The next two > checkins will be: > > 1) the part of GetDFSRefer before the smb send which should work as is > 2) the post-processing (looking at the SMB response buffer and taking > the dfs structs out of it) which Christoph says was too big and needs > to be put in a different function - so needs more coding > > On Wed, May 14, 2008 at 1:50 PM, Steve French wrote: >> Do you have a newer version of the GetDFSRefer patch - or point me to >> which you think is most current? >> >> On Wed, May 14, 2008 at 6:50 AM, Igor Mammedov wrote: >>> Steve French wrote: >>>> Samba was not handling paths without the \\server\share prefix (which >>>> our current code sends on QueryPathInfo) when "SHARE_IN_DFS" on >>>> operations such as rmdir and delete. >>>> >>>> This patch fixes that: >>> >>> >>> Attempted to test patch and >>> >>> - >>> at the first attempt I've got oops caused by a missing CIFSGetDFSRefer patch, >>> after digging it up and applying it, oops is disappeared. But it doesn't >>> help much because your patch broke traversal over a dfs link, at the moment >>> dfs lookup relies on the second lookup attempt with a short path name (without >>> tree name). >>> BTW, you said that you almost made patch for a fake dfs inode, it could fix >>> things up. >>> >>> + >>> mkdir and rmdir on a dfs enabled share work (at least with samba), can't check >>> it on MS however. >>> >>> PS: >>> commiting CIFSGetDFSRefer patch will help to avoid oops-es and more people >>> would be able to test the DFS related patches. >>> >>> -- >>> >>> Best regards, >>> >>> ------------------------- >>> Igor Mammedov, >>> niallain "at" gmail.com >>> >>> >>> >>> >>> >> >> >> >> -- >> Thanks, >> >> Steve >> > > > > -- > Thanks, > > Steve > -- Thanks, Steve