From: "Steve French" <smfrench@gmail.com>
To: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Cc: "Shirish Pargaonkar" <shirishpargaonkar@gmail.com>,
"Dave Kleikamp" <shaggy@linux.vnet.ibm.com>,
"Jody French" <jfrench@austin.rr.com>
Subject: Re: flush and EIO errors when writepages fails
Date: Fri, 20 Jun 2008 17:34:21 -0500 [thread overview]
Message-ID: <524f69650806201534g67704841u9f942a71b6d9caa3@mail.gmail.com> (raw)
> Right, but with the current implementation, once filemap_fdatawrite
> returns, any pages that that run touched are either written out or
> discarded.
That could explain some problems if true. When writepages fails, we
make the pages as in error (PG_error flag?) and presumably they are
still dirty. Why in the world would anyone free the pages just
because we failed the first time and need to write them again later?
Do you where (presumably in /mm) pages could be freed that are still
dirty (it is hard to find where the PG_error flag is checked etc)?
--
Thanks,
Steve
next reply other threads:[~2008-06-20 22:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 22:34 Steve French [this message]
2008-06-21 7:05 ` flush and EIO errors when writepages fails Evgeniy Polyakov
2008-06-21 12:27 ` Jeff Layton
2008-06-21 13:19 ` Evgeniy Polyakov
2008-06-21 14:21 ` Jody French
2008-06-21 14:42 ` Evgeniy Polyakov
2008-06-21 16:15 ` Steve French
2008-06-21 16:28 ` Evgeniy Polyakov
2008-06-21 17:02 ` Steve French
2008-06-21 17:26 ` Evgeniy Polyakov
2008-06-21 17:37 ` Evgeniy Polyakov
2008-06-23 15:39 ` Dave Kleikamp
2008-06-23 18:05 ` Dave Kleikamp
[not found] <20080620073150.2bc9988e@tupile.poochiereds.net>
[not found] ` <OFE8C66E61.981E25D1-ON8725746E.0045A92A-8625746E.004718C0@us.ibm.com>
[not found] ` <20080620091542.09edb43f@tupile.poochiereds.net>
2008-06-20 16:19 ` Steve French (smfltc)
2008-06-20 16:34 ` Jeff Layton
2008-06-20 16:41 ` Steve French (smfltc)
2008-06-20 17:12 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524f69650806201534g67704841u9f942a71b6d9caa3@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=jfrench@austin.rr.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=shirishpargaonkar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).