From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: flush and EIO errors when writepages fails Date: Fri, 20 Jun 2008 17:34:21 -0500 Message-ID: <524f69650806201534g67704841u9f942a71b6d9caa3@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Shirish Pargaonkar" , "Dave Kleikamp" , "Jody French" To: linux-fsdevel Return-path: Received: from fk-out-0910.google.com ([209.85.128.186]:19051 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbYFTWeX (ORCPT ); Fri, 20 Jun 2008 18:34:23 -0400 Received: by fk-out-0910.google.com with SMTP id 18so1431151fkq.5 for ; Fri, 20 Jun 2008 15:34:22 -0700 (PDT) Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > Right, but with the current implementation, once filemap_fdatawrite > returns, any pages that that run touched are either written out or > discarded. That could explain some problems if true. When writepages fails, we make the pages as in error (PG_error flag?) and presumably they are still dirty. Why in the world would anyone free the pages just because we failed the first time and need to write them again later? Do you where (presumably in /mm) pages could be freed that are still dirty (it is hard to find where the PG_error flag is checked etc)? -- Thanks, Steve