From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: [PATCH] do not attempt to close cifs files which are already closed due to session reconnect Date: Thu, 20 Nov 2008 12:55:49 -0600 Message-ID: <524f69650811201055r4f3b912cn2b5d7d4c3b42b2f5@mail.gmail.com> References: <524f69650811181946s79fdba88w11c8c4c6677df1db@mail.gmail.com> <20081119070429.1d977f72@tleilax.poochiereds.net> <524f69650811192124w2677e939l74846ed709335efa@mail.gmail.com> <20081120080241.24e926f4@barsoom.rdu.redhat.com> <524f69650811200604x2e1a5529k5bd1075ca5e53ed0@mail.gmail.com> <20081120093900.44c967d2@barsoom.rdu.redhat.com> <524f69650811200843v4ab856f1r45591871b79a3cc@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_116355_32993213.1227207349782" Cc: linux-fsdevel , "linux-cifs-client@lists.samba.org" To: "Jeff Layton" Return-path: Received: from ey-out-2122.google.com ([74.125.78.27]:16569 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754567AbYKTSzv (ORCPT ); Thu, 20 Nov 2008 13:55:51 -0500 Received: by ey-out-2122.google.com with SMTP id 6so249469eyi.37 for ; Thu, 20 Nov 2008 10:55:49 -0800 (PST) In-Reply-To: <524f69650811200843v4ab856f1r45591871b79a3cc@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: ------=_Part_116355_32993213.1227207349782 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Slightly updated -- Thanks, Steve ------=_Part_116355_32993213.1227207349782 Content-Type: text/x-diff; name=do-not-close-invalid-handle.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_fnrrk8jn0 Content-Disposition: attachment; filename=do-not-close-invalid-handle.patch ZGlmZiAtLWdpdCBhL2ZzL2NpZnMvY2lmc2dsb2IuaCBiL2ZzL2NpZnMvY2lmc2dsb2IuaAppbmRl eCBmMWFlMWY1Li5jNTdjMDU2IDEwMDY0NAotLS0gYS9mcy9jaWZzL2NpZnNnbG9iLmgKKysrIGIv ZnMvY2lmcy9jaWZzZ2xvYi5oCkBAIC02MDYsNyArNjA2LDE1IEBAIEdMT0JBTF9FWFRFUk4gc3Ry dWN0IGxpc3RfaGVhZAkJY2lmc190Y3Bfc2VzX2xpc3Q7CiAgKiBjaGFuZ2VzIHRvIHRoZSB0Y29u LT50aWRTdGF0dXMgc2hvdWxkIGJlIGRvbmUgd2hpbGUgaG9sZGluZyB0aGlzIGxvY2suCiAgKi8K IEdMT0JBTF9FWFRFUk4gcndsb2NrX3QJCWNpZnNfdGNwX3Nlc19sb2NrOwotR0xPQkFMX0VYVEVS TiByd2xvY2tfdCBHbG9iYWxTTUJTZXNsb2NrOyAgLyogcHJvdGVjdHMgbGlzdCBpbnNlcnRzIG9u IDMgYWJvdmUgKi8KKworLyoKKyAqIFRoaXMgbG9jayBwcm90ZWN0cyB0aGUgY2lmc19maWxlLT5s bGlzdCBhbmQgY2lmc19maWxlLT5mbGlzdAorICogbGlzdCBvcGVyYXRpb25zLCBhbmQgdXBkYXRl cyB0byBzb21lIGZsYWdzIChjaWZzX2ZpbGUtPmludmFsaWRIYW5kbGUpCisgKiBJdCB3aWxsIGJl IG1vdmVkIHRvIGVpdGhlciB1c2UgdGhlIHRjb24tPnN0YXRfbG9jayBvciBlcXVpdmFsZW50IGxh dGVyLgorICogSWYgY2lmc190Y3Bfc2VzX2xvY2sgYW5kIHRoZSBsb2NrIGJlbG93IGFyZSBib3Ro IG5lZWRlZCB0byBiZSBoZWxkLCB0aGVuCisgKiB0aGUgY2lmc190Y3Bfc2VzX2xvY2sgbXVzdCBi ZSBncmFiYmVkIGZpcnN0IGFuZCByZWxlYXNlZCBsYXN0LgorICovCitHTE9CQUxfRVhURVJOIHJ3 bG9ja190IEdsb2JhbFNNQlNlc2xvY2s7CiAKIEdMT0JBTF9FWFRFUk4gc3RydWN0IGxpc3RfaGVh ZCBHbG9iYWxPcGxvY2tfUTsKIApkaWZmIC0tZ2l0IGEvZnMvY2lmcy9maWxlLmMgYi9mcy9jaWZz L2ZpbGUuYwppbmRleCA2NDQ5ZTFhLi5iNjkxYjg5IDEwMDY0NAotLS0gYS9mcy9jaWZzL2ZpbGUu YworKysgYi9mcy9jaWZzL2ZpbGUuYwpAQCAtNDg4LDEyICs0ODgsMTMgQEAgaW50IGNpZnNfY2xv c2Uoc3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0IGZpbGUgKmZpbGUpCiAJcFRjb24gPSBjaWZz X3NiLT50Y29uOwogCWlmIChwU01CRmlsZSkgewogCQlzdHJ1Y3QgY2lmc0xvY2tJbmZvICpsaSwg KnRtcDsKLQorCQl3cml0ZV9sb2NrKCZHbG9iYWxTTUJTZXNsb2NrKTsKIAkJcFNNQkZpbGUtPmNs b3NlUGVuZCA9IHRydWU7CiAJCWlmIChwVGNvbikgewogCQkJLyogbm8gc2Vuc2UgcmVjb25uZWN0 aW5nIHRvIGNsb3NlIGEgZmlsZSB0aGF0IGlzCiAJCQkgICBhbHJlYWR5IGNsb3NlZCAqLwogCQkJ aWYgKCFwVGNvbi0+bmVlZF9yZWNvbm5lY3QpIHsKKwkJCQl3cml0ZV91bmxvY2soJkdsb2JhbFNN QlNlc2xvY2spOwogCQkJCXRpbWVvdXQgPSAyOwogCQkJCXdoaWxlICgoYXRvbWljX3JlYWQoJnBT TUJGaWxlLT53cnRQZW5kaW5nKSAhPSAwKQogCQkJCQkmJiAodGltZW91dCA8PSAyMDQ4KSkgewpA QCAtNTEwLDEyICs1MTEsMTUgQEAgaW50IGNpZnNfY2xvc2Uoc3RydWN0IGlub2RlICppbm9kZSwg c3RydWN0IGZpbGUgKmZpbGUpCiAJCQkJCXRpbWVvdXQgKj0gNDsKIAkJCQl9CiAJCQkJaWYgKGF0 b21pY19yZWFkKCZwU01CRmlsZS0+d3J0UGVuZGluZykpCi0JCQkJCWNFUlJPUigxLAotCQkJCQkJ KCJjbG9zZSB3aXRoIHBlbmRpbmcgd3JpdGVzIikpOwotCQkJCXJjID0gQ0lGU1NNQkNsb3NlKHhp ZCwgcFRjb24sCisJCQkJCWNFUlJPUigxLCAoImNsb3NlIHdpdGggcGVuZGluZyB3cml0ZSIpKTsK KwkJCQlpZiAoIXBUY29uLT5uZWVkX3JlY29ubmVjdCAmJgorCQkJCSAgICAhcFNNQkZpbGUtPmlu dmFsaWRIYW5kbGUpCisJCQkJCXJjID0gQ0lGU1NNQkNsb3NlKHhpZCwgcFRjb24sCiAJCQkJCQkg IHBTTUJGaWxlLT5uZXRmaWQpOwotCQkJfQotCQl9CisJCQl9IGVsc2UKKwkJCQl3cml0ZV91bmxv Y2soJkdsb2JhbFNNQlNlc2xvY2spOworCQl9IGVsc2UKKwkJCXdyaXRlX3VubG9jaygmR2xvYmFs U01CU2VzbG9jayk7CiAKIAkJLyogRGVsZXRlIGFueSBvdXRzdGFuZGluZyBsb2NrIHJlY29yZHMu CiAJCSAgIFdlJ2xsIGxvc2UgdGhlbSB3aGVuIHRoZSBmaWxlIGlzIGNsb3NlZCBhbnl3YXkuICov CkBAIC01ODcsMTUgKzU5MSwxOCBAQCBpbnQgY2lmc19jbG9zZWRpcihzdHJ1Y3QgaW5vZGUgKmlu b2RlLCBzdHJ1Y3QgZmlsZSAqZmlsZSkKIAkJcFRjb24gPSBjaWZzX3NiLT50Y29uOwogCiAJCWNG WUkoMSwgKCJGcmVlaW5nIHByaXZhdGUgZGF0YSBpbiBjbG9zZSBkaXIiKSk7CisJCXdyaXRlX2xv Y2soJkdsb2JhbFNNQlNlc2xvY2spOwogCQlpZiAoIXBDRmlsZVN0cnVjdC0+c3JjaF9pbmYuZW5k T2ZTZWFyY2ggJiYKIAkJICAgICFwQ0ZpbGVTdHJ1Y3QtPmludmFsaWRIYW5kbGUpIHsKIAkJCXBD RmlsZVN0cnVjdC0+aW52YWxpZEhhbmRsZSA9IHRydWU7CisJCQl3cml0ZV91bmxvY2soJkdsb2Jh bFNNQlNlc2xvY2spOwogCQkJcmMgPSBDSUZTRmluZENsb3NlKHhpZCwgcFRjb24sIHBDRmlsZVN0 cnVjdC0+bmV0ZmlkKTsKIAkJCWNGWUkoMSwgKCJDbG9zaW5nIHVuY29tcGxldGVkIHJlYWRkaXIg d2l0aCByYyAlZCIsCiAJCQkJIHJjKSk7CiAJCQkvKiBub3QgbXVjaCB3ZSBjYW4gZG8gaWYgaXQg ZmFpbHMgYW55d2F5LCBpZ25vcmUgcmMgKi8KIAkJCXJjID0gMDsKLQkJfQorCQl9IGVsc2UKKwkJ CXdyaXRlX3VubG9jaygmR2xvYmFsU01CU2VzbG9jayk7CiAJCXB0bXAgPSBwQ0ZpbGVTdHJ1Y3Qt PnNyY2hfaW5mLm50d3JrX2J1Zl9zdGFydDsKIAkJaWYgKHB0bXApIHsKIAkJCWNGWUkoMSwgKCJj bG9zZWRpciBmcmVlIHNtYiBidWYgaW4gc3JjaCBzdHJ1Y3QiKSk7CmRpZmYgLS1naXQgYS9mcy9j aWZzL21pc2MuYyBiL2ZzL2NpZnMvbWlzYy5jCmluZGV4IGFkZGQxZGMuLjllZTNmNjggMTAwNjQ0 Ci0tLSBhL2ZzL2NpZnMvbWlzYy5jCisrKyBiL2ZzL2NpZnMvbWlzYy5jCkBAIC01NTUsMTIgKzU1 NSwxNCBAQCBpc192YWxpZF9vcGxvY2tfYnJlYWsoc3RydWN0IHNtYl9oZHIgKmJ1Ziwgc3RydWN0 IFRDUF9TZXJ2ZXJfSW5mbyAqc3J2KQogCQkJCWNvbnRpbnVlOwogCiAJCQljaWZzX3N0YXRzX2lu YygmdGNvbi0+bnVtX29wbG9ja19icmtzKTsKKwkJCXdyaXRlX2xvY2soJkdsb2JhbFNNQlNlc2xv Y2spOwogCQkJbGlzdF9mb3JfZWFjaCh0bXAyLCAmdGNvbi0+b3BlbkZpbGVMaXN0KSB7CiAJCQkJ bmV0ZmlsZSA9IGxpc3RfZW50cnkodG1wMiwgc3RydWN0IGNpZnNGaWxlSW5mbywKIAkJCQkJCSAg ICAgdGxpc3QpOwogCQkJCWlmIChwU01CLT5GaWQgIT0gbmV0ZmlsZS0+bmV0ZmlkKQogCQkJCQlj b250aW51ZTsKIAorCQkJCXdyaXRlX3VubG9jaygmR2xvYmFsU01CU2VzbG9jayk7CiAJCQkJcmVh ZF91bmxvY2soJmNpZnNfdGNwX3Nlc19sb2NrKTsKIAkJCQljRllJKDEsICgiZmlsZSBpZCBtYXRj aCwgb3Bsb2NrIGJyZWFrIikpOwogCQkJCXBDaWZzSW5vZGUgPSBDSUZTX0kobmV0ZmlsZS0+cElu b2RlKTsKQEAgLTU3Niw2ICs1NzgsNyBAQCBpc192YWxpZF9vcGxvY2tfYnJlYWsoc3RydWN0IHNt Yl9oZHIgKmJ1Ziwgc3RydWN0IFRDUF9TZXJ2ZXJfSW5mbyAqc3J2KQogCiAJCQkJcmV0dXJuIHRy dWU7CiAJCQl9CisJCQl3cml0ZV91bmxvY2soJkdsb2JhbFNNQlNlc2xvY2spOwogCQkJcmVhZF91 bmxvY2soJmNpZnNfdGNwX3Nlc19sb2NrKTsKIAkJCWNGWUkoMSwgKCJObyBtYXRjaGluZyBmaWxl IGZvciBvcGxvY2sgYnJlYWsiKSk7CiAJCQlyZXR1cm4gdHJ1ZTsKZGlmZiAtLWdpdCBhL2ZzL2Np ZnMvcmVhZGRpci5jIGIvZnMvY2lmcy9yZWFkZGlyLmMKaW5kZXggNThkNTcyOS4uOWY1MWY5YiAx MDA2NDQKLS0tIGEvZnMvY2lmcy9yZWFkZGlyLmMKKysrIGIvZnMvY2lmcy9yZWFkZGlyLmMKQEAg LTc0MSwxMSArNzQxLDE0IEBAIHN0YXRpYyBpbnQgZmluZF9jaWZzX2VudHJ5KGNvbnN0IGludCB4 aWQsIHN0cnVjdCBjaWZzVGNvbkluZm8gKnBUY29uLAogCSAgIChpbmRleF90b19maW5kIDwgZmly c3RfZW50cnlfaW5fYnVmZmVyKSkgewogCQkvKiBjbG9zZSBhbmQgcmVzdGFydCBzZWFyY2ggKi8K IAkJY0ZZSSgxLCAoInNlYXJjaCBiYWNraW5nIHVwIC0gY2xvc2UgYW5kIHJlc3RhcnQgc2VhcmNo IikpOworCQl3cml0ZV9sb2NrKCZHbG9iYWxTTUJTZXNsb2NrKTsKIAkJaWYgKCFjaWZzRmlsZS0+ c3JjaF9pbmYuZW5kT2ZTZWFyY2ggJiYKIAkJICAgICFjaWZzRmlsZS0+aW52YWxpZEhhbmRsZSkg ewogCQkJY2lmc0ZpbGUtPmludmFsaWRIYW5kbGUgPSB0cnVlOworCQkJd3JpdGVfdW5sb2NrKCZH bG9iYWxTTUJTZXNsb2NrKTsKIAkJCUNJRlNGaW5kQ2xvc2UoeGlkLCBwVGNvbiwgY2lmc0ZpbGUt Pm5ldGZpZCk7Ci0JCX0KKwkJfSBlbHNlCisJCQl3cml0ZV91bmxvY2soJkdsb2JhbFNNQlNlc2xv Y2spOwogCQlpZiAoY2lmc0ZpbGUtPnNyY2hfaW5mLm50d3JrX2J1Zl9zdGFydCkgewogCQkJY0ZZ SSgxLCAoImZyZWVpbmcgU01CIGZmIGNhY2hlIGJ1ZiBvbiBzZWFyY2ggcmV3aW5kIikpOwogCQkJ aWYgKGNpZnNGaWxlLT5zcmNoX2luZi5zbWFsbEJ1ZikK ------=_Part_116355_32993213.1227207349782--