From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: [linux-cifs-client] Re: fsx-linux failing with latest cifs-2.6 git tree Date: Tue, 25 Nov 2008 22:04:04 -0600 Message-ID: <524f69650811252004nfc7936bga8aa0d34ef487cd@mail.gmail.com> References: <20081121105613.09a8cb8e@tleilax.poochiereds.net> <20081121235346.GB9857@wotan.suse.de> <20081121205151.1e3a09fe@tleilax.poochiereds.net> <524f69650811211802x74c0cadaided4c09f6c9e790e@mail.gmail.com> <1227329229.29807.9.camel@norville.austin.ibm.com> <20081122103916.6d9fc4e6@tleilax.poochiereds.net> <1227385664.10953.4.camel@norville.austin.ibm.com> <20081123065715.029b6ceb@tleilax.poochiereds.net> <524f69650811231832v12a03252ycbf53d9b06f178f8@mail.gmail.com> <20081124061918.7376c1ce@tleilax.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Nick Piggin" , linux-fsdevel , pbadari@us.ibm.com, "linux-cifs-client@lists.samba.org" To: "Jeff Layton" Return-path: Received: from ey-out-2122.google.com ([74.125.78.27]:40796 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752249AbYKZEEI (ORCPT ); Tue, 25 Nov 2008 23:04:08 -0500 Received: by ey-out-2122.google.com with SMTP id 6so124608eyi.37 for ; Tue, 25 Nov 2008 20:04:05 -0800 (PST) In-Reply-To: <20081124061918.7376c1ce@tleilax.poochiereds.net> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Do you know why someone added the AOP_FLAG_UNITERRUPTIBLE check in cifs_write_begin instead of always marking a page up to date if we are writing the whole page? How often would that flag be set - I only see it in the path which calls generic_file_buffered_write /* If we are writing a full page it will be up to date, no need to read from the server */ if (len == PAGE_CACHE_SIZE && flags & AOP_FLAG_UNINTERRUPTIBLE) It seems restrictive On Mon, Nov 24, 2008 at 5:19 AM, Jeff Layton wrote: > On Sun, 23 Nov 2008 20:32:05 -0600 > "Steve French" wrote: > >> Looks fine to me, you can add in the acked-by ... if Dave or Nick >> agree and it tests out ok then I will push to cifs-2.6.git within next >> day or so. >> > > Testing seems fine with this patch. Connectathon suite still passes, > and fsx and fsstress both ran overnight without errors. > > -- > Jeff Layton > -- Thanks, Steve