From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve French" Subject: Re: [PATCH] cifs: remove dnotify thread code Date: Fri, 9 Jan 2009 10:18:28 -0600 Message-ID: <524f69650901090818w7f367832vb9d0979714c3c609@mail.gmail.com> References: <1231424128-5598-1-git-send-email-jlayton@redhat.com> <524f69650901080623s228c343eka791c089c878167@mail.gmail.com> <20090109000708.GC12848@shareable.org> <524f69650901081932m2912ab73x147221f721194f8@mail.gmail.com> <20090109063318.04f260d1@tleilax.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org, Jamie Lokier To: "Jeff Layton" Return-path: In-Reply-To: <20090109063318.04f260d1@tleilax.poochiereds.net> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org Errors-To: linux-cifs-client-bounces+glfc-linux-cifs-client=gmane.org@lists.samba.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jan 9, 2009 at 5:33 AM, Jeff Layton wrote: > On Thu, 8 Jan 2009 21:32:09 -0600 > "Steve French" wrote: > This patch doesn't remove any capability of the current code. It just > gets rid of this kthread that doesn't do anything useful. There's > nothing stopping us from putting it back later once we have working dir > notification, but until then it's just doing unnecessary wakeups. Al's patch removes the ability for a network or cluster file system to handle directory change notification in the future ... (AFAIK KDE, GNOME still use this fcntl) so we won't be able to fix the fcntl to work where it matters most (network or cluster environments) in the future without reverting the patch. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=6badd79bd002788aaec27b50a74ab69ef65ab8ee --- a/fs/dnotify.c +++ b/fs/dnotify.c @@ -115,9 +115,6 @@ int fcntl_dirnotify(int fd, struct file *filp, unsigned long arg) dn->dn_next = inode->i_dnotify; inode->i_dnotify = dn; spin_unlock(&inode->i_lock); - - if (filp->f_op && filp->f_op->dir_notify) - return filp->f_op->dir_notify(filp, arg); return 0; -- Thanks, Steve