From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve French Subject: Re: [PATCH] Add CONFIG_VFAT_NO_CREATE_WITH_LONGNAMES option Date: Fri, 1 May 2009 22:02:38 -0500 Message-ID: <524f69650905012002u190f357ax5fad7f3d8d660bcf@mail.gmail.com> References: <524f69650905011318m34e0027dt57877d225b3fe2da@mail.gmail.com> <20090501210109.GA3079@infradead.org> <20090502013729.GI6996@linux.vnet.ibm.com> <20090502015927.GJ8822@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "Paul E. McKenney" , Christoph Hellwig , Dave Kleikamp , Ogawa Hirofumi , linux-fsdevel , Michael Tokarev , Andrew Tridgell , LKML To: Matthew Wilcox Return-path: Received: from yx-out-2324.google.com ([74.125.44.30]:55928 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751191AbZEBDCj convert rfc822-to-8bit (ORCPT ); Fri, 1 May 2009 23:02:39 -0400 In-Reply-To: <20090502015927.GJ8822@parisc-linux.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, May 1, 2009 at 8:59 PM, Matthew Wilcox wrote: > On Fri, May 01, 2009 at 06:37:29PM -0700, Paul E. McKenney wrote: >> However, as far as I know, none of us are lawyers, and LKML is defin= itely >> a technical rather than a legal forum, so we really do need to stick= to >> technical topics. =A0I understand that this might be a bit frustrati= ng >> to you. =A0On the other hand, I for one much prefer being in a forum >> restricted to technical topics than to be in those places designed t= o >> handle legal topics! > > So what's the purely technical argument for including this patch? The strength of Tridge's approach over alternatives may be that it is c= learer to only create one name (always) and that it is relatively small. Its weakness in my opinion is that as a sideeffect it prevents saving m= ixed case file names. There are various ways to disable (only) creating long file names, ie to remove the ability to create files longer than 8.3 from this module. Tridge's approach (= which basically avoids saving the alternate name, the mixed case name) works. I realize that there are other ways to do this with trivial #ifdefs in namei_vfat.c (see vfat_build_slots and vfat_create_shortname), and when I tried other app= roaches they worked too, although you may prefer Tridge's approach. --=20 Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html