From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gu Zheng Subject: Re: [PATCH] f2fs: delete and free dirty dir freeing inode entry when sync dirty dir inodes Date: Wed, 23 Oct 2013 18:11:03 +0800 Message-ID: <5267A0B7.7000202@cn.fujitsu.com> References: <5264D574.6000105@cn.fujitsu.com> <1382440544.992.64.camel@kjgkr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: f2fs , fsdevel , linux-kernel To: jaegeuk.kim@samsung.com Return-path: In-Reply-To: <1382440544.992.64.camel@kjgkr> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi Kim, On 10/22/2013 07:15 PM, Jaegeuk Kim wrote: > 2013-10-21 (=EC=9B=94), 15:19 +0800, Gu Zheng: >> In sync_dirty_dir_inodes(), remove_dirty_dir_inode() will be called >> in the callback of filemap_flush to delete and free dirty dir inode = entry. >> But for the freeing inode entry, missed this step after sbumit data = bio, >> and this may lead to a dead loop if these is freeing inode entry in >> dir_inode_list. So add the delete and free step to fix it. >=20 > Hi Gu, >=20 > This dirty inode will be removed by f2fs_evict_inode() after submitti= ng > any pending bio, f2fs_submit_bio(). Yeah, got it, thanks for your direction, please ignore this patch. Regards, Gu > Thanks, >=20 >> >> Signed-off-by: Gu Zheng >> --- >> fs/f2fs/checkpoint.c | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c >> index 8d16071..f61838f 100644 >> --- a/fs/f2fs/checkpoint.c >> +++ b/fs/f2fs/checkpoint.c >> @@ -600,7 +600,16 @@ retry: >> * wribacking dentry pages in the freeing inode. >> */ >> f2fs_submit_bio(sbi, DATA, true); >> + >> + spin_lock(&sbi->dir_inode_lock); >> + list_del(&entry->list); >> +#ifdef CONFIG_F2FS_STAT_FS >> + sbi->n_dirty_dirs--; >> +#endif >> + spin_unlock(&sbi->dir_inode_lock); >> + kmem_cache_free(inode_entry_slab, entry); >> } >> + >> goto retry; >> } >> =20 >=20