From: Dave Hansen <dave.hansen@intel.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>, viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
Chandra Seetharaman <sekharan@us.ibm.com>
Subject: Re: [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage
Date: Mon, 11 Nov 2013 14:15:00 -0800 [thread overview]
Message-ID: <528156E4.1030409@intel.com> (raw)
In-Reply-To: <1383745544-391-8-git-send-email-zwu.kernel@gmail.com>
On 11/06/2013 05:45 AM, Zhi Yong Wu wrote:
> Introduce a /proc interface hot-mem-high-thresh and
> to cap the memory which is consumed by hot_inode_item
> and hot_range_item, and they will be in the unit of
> 1M bytes.
You don't seem to have any documentation for this, btw... :(
> + .procname = "hot-mem-high-thresh",
*Always* put units on these. I know you mention it in a code comment,
but please also include it in the proc filename too.
In general, why do you have to control the number of these statically?
Shouldn't you just define a shrinker and let memory pressure determine
how many of these we allow to exist?
next prev parent reply other threads:[~2013-11-11 22:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 13:45 [PATCH v6 00/11] VFS hot tracking Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 01/11] VFS hot tracking: Define basic data structures and functions Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 02/11] VFS hot tracking: Track IO and record heat information Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 03/11] VFS hot tracking: Add a workqueue to move items between hot maps Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 04/11] VFS hot tracking: Add shrinker functionality to curtail memory usage Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 05/11] VFS hot tracking: Add an ioctl to get hot tracking information Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 06/11] VFS hot tracking: Add a /proc interface to make the interval tunable Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 07/11] VFS hot tracking: Add a /proc interface to control memory usage Zhi Yong Wu
2013-11-11 22:15 ` Dave Hansen [this message]
2013-11-11 22:45 ` Zhi Yong Wu
2013-11-12 17:05 ` Dave Hansen
2013-11-12 20:38 ` Zhi Yong Wu
2013-11-12 21:02 ` Dave Hansen
2013-11-12 21:56 ` Zhi Yong Wu
2013-12-11 15:44 ` Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 08/11] VFS hot tracking: Add documentation Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 09/11] VFS hot tracking, btrfs: Add hot tracking support Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 10/11] VFS hot tracking, xfs: " Zhi Yong Wu
2013-11-06 13:45 ` [PATCH v6 11/11] MAINTAINERS: add the maintainers for VFS hot tracking Zhi Yong Wu
2013-11-11 15:43 ` [PATCH v6 00/11] " Zhi Yong Wu
2013-11-13 18:33 ` Zhi Yong Wu
2013-11-21 13:57 ` Zhi Yong Wu
2013-11-30 9:55 ` Zhi Yong Wu
2013-12-03 20:16 ` Zhi Yong Wu
2013-12-11 15:45 ` Zhi Yong Wu
2014-07-17 19:35 ` The VFS hot tracking debacle Daniel Poelzleithner
2014-07-17 21:34 ` Martin Steigerwald
2014-07-17 21:52 ` Dave Chinner
2014-07-18 8:25 ` Martin Steigerwald
2014-07-20 0:02 ` Dave Chinner
2014-07-25 8:43 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528156E4.1030409@intel.com \
--to=dave.hansen@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sekharan@us.ibm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).