From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f196.google.com ([209.85.166.196]:33758 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726732AbeLAES1 (ORCPT ); Fri, 30 Nov 2018 23:18:27 -0500 Received: by mail-it1-f196.google.com with SMTP id m8so2439255itk.0 for ; Fri, 30 Nov 2018 09:08:29 -0800 (PST) Subject: Re: [PATCH 01/27] aio: fix failure to put the file pointer To: Bart Van Assche , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org Cc: hch@lst.de References: <20181130165646.27341-1-axboe@kernel.dk> <20181130165646.27341-2-axboe@kernel.dk> <1543597666.4347.1.camel@acm.org> From: Jens Axboe Message-ID: <52910028-205c-adc5-acc0-3f03e35ece66@kernel.dk> Date: Fri, 30 Nov 2018 10:08:27 -0700 MIME-Version: 1.0 In-Reply-To: <1543597666.4347.1.camel@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 11/30/18 10:07 AM, Bart Van Assche wrote: > On Fri, 2018-11-30 at 09:56 -0700, Jens Axboe wrote: >> If the ioprio capability check fails, we return without putting >> the file pointer. >> >> Fixes: d9a08a9e616b ("fs: Add aio iopriority support") >> Reviewed-by: Johannes Thumshirn >> Reviewed-by: Christoph Hellwig >> Signed-off-by: Jens Axboe >> --- >> fs/aio.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/aio.c b/fs/aio.c >> index b984918be4b7..205390c0c1bb 100644 >> --- a/fs/aio.c >> +++ b/fs/aio.c >> @@ -1436,6 +1436,7 @@ static int aio_prep_rw(struct kiocb *req, struct iocb *iocb) >> ret = ioprio_check_cap(iocb->aio_reqprio); >> if (ret) { >> pr_debug("aio ioprio check cap error: %d\n", ret); >> + fput(req->ki_filp); >> return ret; >> } > > Since this patch fixes a bug that was introduced in kernel v4.18, does this > patch need a "Cc: stable" tag? The fixes should take care of that by itself, I hope. -- Jens Axboe