linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Priebe <s.priebe@profihost.ag>
To: Ric Wheeler <rwheeler@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	Chinmay V S <cvs268@gmail.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	Theodore Ts'o <tytso@mit.edu>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <matthew@wil.cx>
Subject: Re: Why is O_DSYNC on linux so slow / what's wrong with my SSD?
Date: Sat, 23 Nov 2013 20:48:09 +0100	[thread overview]
Message-ID: <52910679.6030609@profihost.ag> (raw)
In-Reply-To: <5291038E.4000908@redhat.com>

Hi Ric,

Am 23.11.2013 20:35, schrieb Ric Wheeler:
> On 11/23/2013 01:27 PM, Stefan Priebe wrote:
>> Hi Ric,
>>
>> Am 22.11.2013 21:37, schrieb Ric Wheeler:
>>> On 11/22/2013 03:01 PM, Stefan Priebe wrote:
>>>> Hi Christoph,
>>>> Am 21.11.2013 11:11, schrieb Christoph Hellwig:
>>>>>>
>>>>>> 2. Some drives may implement CMD_FLUSH to return immediately i.e. no
>>>>>> guarantee the data is actually on disk.
>>>>>
>>>>> In which case they aren't spec complicant.  While I've seen countless
>>>>> data integrity bugs on lower end ATA SSDs I've not seen one that
>>>>> simpliy
>>>>> ingnores flush.  If you'd want to cheat that bluntly you'd be better
>>>>> of just claiming to not have a writeback cache.
>>>>>
>>>>> You solve your performance problem by completely disabling any chance
>>>>> of having data integrity guarantees, and do so in a way that is not
>>>>> detectable for applications or users.
>>>>>
>>>>> If you have a workload with lots of small synchronous writes disabling
>>>>> the writeback cache on the disk does indeed often help, especially
>>>>> with
>>>>> the non-queueable FLUSH on all but the most recent ATA devices.
>>>>
>>>> But this isn't correct for drives with capicitors like Crucial m500,
>>>> Intel DC S3500, DC S3700 isn't it? Shouldn't the linux kernel has an
>>>> option to disable this for drives like these?
>>>> /sys/block/sdX/device/ignore_flush
>>>
>>> If you know 100% for sure that your drive has a non-volatile write
>>> cache, you can run the file system without the flushing by mounting "-o
>>> nobarrier".  With most devices, this is not needed since they tend to
>>> simply ignore the flushes if they know they are power failure safe.
>>>
>>> Block level, we did something similar for users who are not running
>>> through a file system for SCSI devices - James added support to echo
>>> "temporary" into the sd's device's cache_type field:
>>>
>>> See:
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=2ee3e26c673e75c05ef8b914f54fadee3d7b9c88
>>>
>>
>> At least to me this does not work. I get the same awful speed as
>> before - also the I/O waits stay the same. I'm still seeing CMD
>> flushes going to the devices.
>>
>> Is there any way to check whether the temporary got accepted and works?
>>
>> I simply executed:
>> for i in /sys/class/scsi_disk/*/cache_type; do echo $i; echo temporary
>> write back >$i; done
>>
>> Stefan
>
> What kernel are you running?  This is a new addition....

3.10.19

> Also, you can "cat" the same file to see what it says.

Sure:
[cloud2-1338: ~]# for i in /sys/class/scsi_disk/*/cache_type; do echo 
$i; echo temporary write through >$i; done
/sys/class/scsi_disk/1:0:0:0/cache_type
/sys/class/scsi_disk/2:0:0:0/cache_type
/sys/class/scsi_disk/3:0:0:0/cache_type
/sys/class/scsi_disk/4:0:0:0/cache_type
/sys/class/scsi_disk/5:0:0:0/cache_type
/sys/class/scsi_disk/6:0:0:0/cache_type
[cloud2-1338: ~]# for i in /sys/class/scsi_disk/*/cache_type; do echo 
$i; cat $i; done
/sys/class/scsi_disk/1:0:0:0/cache_type
write through
/sys/class/scsi_disk/2:0:0:0/cache_type
write through
/sys/class/scsi_disk/3:0:0:0/cache_type
write through
/sys/class/scsi_disk/4:0:0:0/cache_type
write through
/sys/class/scsi_disk/5:0:0:0/cache_type
write through
/sys/class/scsi_disk/6:0:0:0/cache_type
write through
[cloud2-1338: ~]# for i in /sys/class/scsi_disk/*/cache_type; do echo 
$i; echo temporary write back >$i; done
/sys/class/scsi_disk/1:0:0:0/cache_type
/sys/class/scsi_disk/2:0:0:0/cache_type
/sys/class/scsi_disk/3:0:0:0/cache_type
/sys/class/scsi_disk/4:0:0:0/cache_type
/sys/class/scsi_disk/5:0:0:0/cache_type
/sys/class/scsi_disk/6:0:0:0/cache_type
[cloud2-1338: ~]# for i in /sys/class/scsi_disk/*/cache_type; do echo 
$i; cat $i; done
/sys/class/scsi_disk/1:0:0:0/cache_type
write back
/sys/class/scsi_disk/2:0:0:0/cache_type
write back
/sys/class/scsi_disk/3:0:0:0/cache_type
write back
/sys/class/scsi_disk/4:0:0:0/cache_type
write back
/sys/class/scsi_disk/5:0:0:0/cache_type
write back
/sys/class/scsi_disk/6:0:0:0/cache_type
write back
[cloud2-1338: ~]#

Stefan

  reply	other threads:[~2013-11-23 19:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 12:12 Why is O_DSYNC on linux so slow / what's wrong with my SSD? Stefan Priebe - Profihost AG
2013-11-20 12:54 ` Christoph Hellwig
2013-11-20 13:34   ` Chinmay V S
2013-11-20 13:38     ` Christoph Hellwig
2013-11-20 14:12     ` Stefan Priebe - Profihost AG
2013-11-20 15:22       ` Chinmay V S
2013-11-20 15:37         ` Theodore Ts'o
2013-11-20 15:55           ` J. Bruce Fields
2013-11-20 17:11             ` Chinmay V S
2013-11-20 17:58               ` J. Bruce Fields
2013-11-20 18:43                 ` Chinmay V S
2013-11-21 10:11                   ` Christoph Hellwig
2013-11-22 20:01                     ` Stefan Priebe
2013-11-22 20:37                       ` Ric Wheeler
2013-11-22 21:05                         ` Stefan Priebe
2013-11-23 18:27                         ` Stefan Priebe
2013-11-23 19:35                           ` Ric Wheeler
2013-11-23 19:48                             ` Stefan Priebe [this message]
2013-11-25  7:37                             ` Stefan Priebe
2020-01-08  6:58                             ` slow sync performance on LSI / Broadcom MegaRaid performance with battery cache Stefan Priebe - Profihost AG
2013-11-22 19:57             ` Why is O_DSYNC on linux so slow / what's wrong with my SSD? Stefan Priebe
2013-11-24  0:10               ` One Thousand Gnomes
2013-11-20 16:02           ` Howard Chu
2013-11-23 20:36             ` Pavel Machek
2013-11-23 23:01               ` Ric Wheeler
2013-11-24  0:22                 ` Pavel Machek
2013-11-24  1:03                   ` One Thousand Gnomes
2013-11-24  2:43                   ` Ric Wheeler
2013-11-22 19:55         ` Stefan Priebe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52910679.6030609@profihost.ag \
    --to=s.priebe@profihost.ag \
    --cc=bfields@fieldses.org \
    --cc=cvs268@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=rwheeler@redhat.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).