linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-fsdevel@vger.kernel.org
Cc: viro@ZenIV.linux.org.uk, Christoph Hellwig <hch@infradead.org>,
	Eric Sandeen <sandeen@sandeen.net>
Subject: Re: Common error in case  of running out of the number of ACL entries
Date: Fri, 13 Dec 2013 23:02:52 +0800	[thread overview]
Message-ID: <52AB219C.6070806@oracle.com> (raw)
In-Reply-To: <52AB1D21.3000702@oracle.com>

On 12/13 2013 22:43 PM, Jeff Liu wrote:
> Hi Folks,
> 
> While looking into the behaviour of XFS in case of running out of the
> maximum number of supported acl entries, I observed that we would
> return various different errors in this situation.  As per Christoph's
> suggestion, I gathered up them from some common file systems with a
> simple tests which were shown as following:
> 
> Btrfs: No space left on device (ENOSPC)
> Ext3: No space left on device (ENOSPC)
> Ext4: No space left oo long (E2BIG)
Sorry, copy-to-paste error. :)

Same to Ext3, Ext4 also return ENOSPC.  Instead, JFS would return E2BIG
as "Argument list too long".  Also, I'm willing to collect further more
info for other file systems resides at fs/ as far as I can if required.

> F2fs: Numerical result out of range (ERANGE)
> OCFS2: Argument list too long (E2BIG)
> XFS: Invalid argument (EINVAL)
> 
> It seems that return either above error would mislead the end user, though
> Eric's Sandeen once pointed out that ENOSPC should be used in this case in
> terms of the setxattr(2) man page.
> <quote>
>        If there is insufficient space remaining to store the extended attribute,
>        errno is set to either ENOSPC, or EDQUOT if quota enforcement was the cause.
> 
> However, the "insufficient space" is obscure, it might be the file system
> space or no more space in metadata blocks, etc...
> 
> Hence, should we consolidate this scenario to figure out a more clearer
> common error?

Thanks,
-Jeff

  reply	other threads:[~2013-12-13 15:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 14:43 Common error in case of running out of the number of ACL entries Jeff Liu
2013-12-13 15:02 ` Jeff Liu [this message]
2013-12-13 16:16 ` Carlos Maiolino
2013-12-13 23:51   ` Dave Chinner
2013-12-14  8:52     ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AB219C.6070806@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).