From: Li Wang <liwang@ubuntukylin.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Sage Weil <sage@inktank.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>,
Yunchuan Wen <yunchuanwen@ubuntukylin.com>
Subject: Re: [PATCH 0/5] VFS: Directory level cache cleaning
Date: Tue, 17 Dec 2013 15:23:15 +0800 [thread overview]
Message-ID: <52AFFBE3.8020507@ubuntukylin.com> (raw)
In-Reply-To: <20131217035847.GA10392@parisc-linux.org>
If we do wanna equip fadvise() with directory level page cache cleaning,
this could be solved by invoking (inode_permission() ||
capable(CAP_SYS_ADMIN)) before manipulating the page cache of that inode.
We think the current extension to 'drop_caches' has a complete back
compatibility, the old semantics keep unchanged, and with add-on
features to do finer granularity cache cleaning should be also
desirable.
On 2013/12/17 11:58, Matthew Wilcox wrote:
> On Tue, Dec 17, 2013 at 11:08:16AM +0800, Li Wang wrote:
>> As far as we know, fadvise(DONTNEED) does not support metadata
>> cache cleaning. We think that is desirable under massive small files
>> situations. Another thing is that do people accept the behavior
>> of feeding a directory fd to fadvise will recusively clean all
>> page caches of files inside that directory?
>
> I think there's a really good permissions-related question here.
> If that's an acceptable interface, should one have to be CAP_SYS_ADMIN
> to issue the request? What if some of the files below this directory
> are not owned by the user issuing the request?
>
>> On 2013/12/17 1:45, Cong Wang wrote:
>>> On Mon, Dec 16, 2013 at 7:00 AM, Li Wang <liwang@ubuntukylin.com> wrote:
>>>> This patch extend the 'drop_caches' interface to
>>>> support directory level cache cleaning and has a complete
>>>> backward compatibility. '{1,2,3}' keeps the same semantics
>>>> as before. Besides, "{1,2,3}:DIRECTORY_PATH_NAME" is allowed
>>>> to recursively clean the caches under DIRECTORY_PATH_NAME.
>>>> For example, 'echo 1:/home/foo/jpg > /proc/sys/vm/drop_caches'
>>>> will clean the page caches of the files inside 'home/foo/jpg'.
>>>>
>>>
>>> This interface is ugly...
>>>
>>> And we already have a file-level drop cache, that is,
>>> fadvise(DONTNEED). Can you extend it if it can't
>>> handle a directory fd?
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-12-17 7:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 15:00 [PATCH 0/5] VFS: Directory level cache cleaning Li Wang
2013-12-16 15:00 ` [PATCH 1/5] VFS: Convert drop_caches to accept string Li Wang
2013-12-16 15:00 ` [PATCH 2/5] VFS: Convert sysctl_drop_caches to string Li Wang
2013-12-16 15:00 ` [PATCH 3/5] VFS: Add the declaration of shrink_pagecache_parent Li Wang
2013-12-16 15:00 ` [PATCH 4/5] VFS: Add shrink_pagecache_parent Li Wang
2013-12-16 15:00 ` [PATCH 5/5] VFS: Extend drop_caches sysctl handler to allow directory level cache cleaning Li Wang
2013-12-16 17:45 ` [PATCH 0/5] VFS: Directory " Cong Wang
2013-12-17 3:08 ` Li Wang
2013-12-17 3:58 ` Matthew Wilcox
2013-12-17 7:23 ` Li Wang [this message]
2013-12-17 9:12 ` Li Zefan
2013-12-17 9:31 ` Li Wang
2013-12-18 1:26 ` Li Zefan
2013-12-17 13:55 ` Michal Hocko
2013-12-17 22:05 ` Dave Chinner
2013-12-18 1:36 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AFFBE3.8020507@ubuntukylin.com \
--to=liwang@ubuntukylin.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=sage@inktank.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
--cc=yunchuanwen@ubuntukylin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).