From: Josef Bacik <jbacik@fb.com>
To: Andreas Dilger <adilger@dilger.ca>, Jan Kara <jack@suse.cz>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Jeff Liu <jeff.liu@oracle.com>
Subject: Re: [PATCH] vfs: Return EINVAL for default SEEK_HOLE, SEEK_DATA implementation
Date: Sat, 4 Jan 2014 19:36:12 -0500 [thread overview]
Message-ID: <52C8A8FC.4080201@fb.com> (raw)
In-Reply-To: <19710447-69E6-47A2-A679-68552967A750@dilger.ca>
On 01/03/2014 05:17 PM, Andreas Dilger wrote:
> Shouldn't this be -EOPNOTSUPP, since -EINVAL is for incorrect arguments, which isn't the case here.
>
I think we want to be consistent with previous kernels which would
return -EINVAL if whence wasn't set properly, hopefully breaking as few
userspace stuff as possible. Thanks,
Josef
next prev parent reply other threads:[~2014-01-05 0:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 10:35 [PATCH] vfs: Return EINVAL for default SEEK_HOLE, SEEK_DATA implementation Jan Kara
2014-01-03 22:17 ` Andreas Dilger
2014-01-05 0:36 ` Josef Bacik [this message]
2014-01-06 9:32 ` Jeff Liu
2014-01-06 10:11 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C8A8FC.4080201@fb.com \
--to=jbacik@fb.com \
--cc=adilger@dilger.ca \
--cc=jack@suse.cz \
--cc=jeff.liu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).