From mboxrd@z Thu Jan  1 00:00:00 1970
From: Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] vfs: Return EINVAL for default SEEK_HOLE, SEEK_DATA implementation
Date: Sat, 4 Jan 2014 19:36:12 -0500
Message-ID: <52C8A8FC.4080201@fb.com>
References: <1388745326-13226-1-git-send-email-jack@suse.cz> <19710447-69E6-47A2-A679-68552967A750@dilger.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Al Viro <viro@ZenIV.linux.org.uk>, "Theodore Ts'o" <tytso@mit.edu>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Jeff Liu <jeff.liu@oracle.com>
To: Andreas Dilger <adilger@dilger.ca>, Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:4351 "EHLO
	mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1754579AbaAEAg0 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 4 Jan 2014 19:36:26 -0500
In-Reply-To: <19710447-69E6-47A2-A679-68552967A750@dilger.ca>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>


On 01/03/2014 05:17 PM, Andreas Dilger wrote:
> Shouldn't this be -EOPNOTSUPP, since -EINVAL is for incorrect arguments, which isn't the case here.
>
I think we want to be consistent with previous kernels which would 
return -EINVAL if whence wasn't set properly, hopefully breaking as few 
userspace stuff as possible.  Thanks,

Josef