From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [block:for-3.14/core] kernel BUG at fs/bio.c:1748 Date: Wed, 08 Jan 2014 14:21:04 -0700 Message-ID: <52CDC140.6090307@kernel.dk> References: <20140102053101.GA29352@localhost> <20140106221036.GE9037@kmo> <20140107055318.GA19016@localhost> <1389215654.23310.39.camel@ret.masoncoding.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-7 Content-Transfer-Encoding: 7bit Cc: "kmo@daterainc.com" , "linux-btrfs@vger.kernel.org" , "fengguang.wu@intel.com" , "linux-kernel@vger.kernel.org" , "lkp@linux.intel.com" , "linux-fsdevel@vger.kernel.org" To: Chris Mason , "muthu.lkml@gmail.com" Return-path: In-Reply-To: <1389215654.23310.39.camel@ret.masoncoding.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 01/08/2014 02:13 PM, Chris Mason wrote: > On Tue, 2014-01-07 at 12:15 -0800, Muthu Kumar wrote: >> Thanks Fengguang. Final patch with added comment. BTW, fengguang >> mentioned that git-am has trouble with the inline patch and "quilt >> import" worked fine for him... >> >> ------------ >> In btrfs_end_bio(), we increment bi_remaining if is_orig_bio. If not, >> we restore the orig_bio but failed to increment bi_remaining for >> orig_bio, which triggers a BUG_ON later when bio_endio is called. Fix >> is to increment bi_remaining when we restore the orig bio as well. >> >> Reported-and-Tested-by: Fengguang wu >> CC: Kent Overstreet >> CC: Jens Axboe >> CC: Chris Mason >> Signed-off-by: Muthukumar Ratty >> > > Reviewed-by: Chris Mason > > Jens, please pull this one in. Done, with the added reviewed and tested-by's. -- Jens Axboe