From: Richard Weinberger <richard@nod.at>
To: Andrew Ruder <andrew.ruder@elecsyscorp.com>,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [HACK] fs/super.c: sync ro remount after blocking writers
Date: Fri, 31 Jan 2014 09:20:30 +0100 [thread overview]
Message-ID: <52EB5CCE.5080609@nod.at> (raw)
In-Reply-To: <1391095614-21554-1-git-send-email-andrew.ruder@elecsyscorp.com>
Am 30.01.2014 16:26, schrieb Andrew Ruder:
> Move sync_filesystem() after sb_prepare_remount_readonly(). If writers
> sneak in anywhere from sync_filesystem() to sb_prepare_remount_readonly()
> it can cause inodes to be dirtied and writeback to occur well after
> sys_mount() has completely successfully.
>
> This was spotted by corrupted ubifs filesystems on reboot, but appears
> that it can cause issues with any filesystem using writeback.
Link to original report:
http://lists.infradead.org/pipermail/linux-mtd/2014-January/051651.html
What we see is that writeback still happens after mounting the fs ro.
Thanks,
//richard
next prev parent reply other threads:[~2014-01-31 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 15:26 [HACK] fs/super.c: sync ro remount after blocking writers Andrew Ruder
2014-01-31 8:20 ` Richard Weinberger [this message]
2014-02-03 10:23 ` Christoph Hellwig
2014-02-28 9:25 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52EB5CCE.5080609@nod.at \
--to=richard@nod.at \
--cc=andrew.ruder@elecsyscorp.com \
--cc=dedekind1@gmail.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).