From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Kleikamp <dave.kleikamp@oracle.com>
Subject: Re: [PATCH] jfs: fix generic posix ACL regression
Date: Sat, 08 Feb 2014 10:37:25 -0600
Message-ID: <52F65D45.5070206@oracle.com>
References: <52F54928.9050601@oracle.com> <20140208070818.GA8758@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: "Michael L. Semon" <mlsemon35@gmail.com>,
	JFS Discussion <jfs-discussion@lists.sourceforge.net>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20140208070818.GA8758@lst.de>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On 02/08/2014 01:08 AM, Christoph Hellwig wrote:
> On Fri, Feb 07, 2014 at 02:59:20PM -0600, Dave Kleikamp wrote:
>> -#ifdef JFS_POSIX_ACL
>> +#ifdef CONFIG_JFS_POSIX_ACL
> 
> Ooops, sorry.
> 
> I don't understand the can_set_xattr move - while the check obviously
> aren't needed when using the generic xattr code I don't see how they
> cause harm either.

Your patchset removed the XATTR_SYSTEM_PREFIX bits from can_set_xattr,
so it will not recognize the ACL as valid and return -EOPNOTSUPP.