From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Weinberger <richard@nod.at>
Subject: Re: [HACK] fs/super.c: sync ro remount after blocking writers
Date: Fri, 28 Feb 2014 10:25:24 +0100
Message-ID: <53105604.4050501@nod.at>
References: <1391095614-21554-1-git-send-email-andrew.ruder@elecsyscorp.com> <20140203102303.GB11829@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>,
	Andrew Ruder <andrew.ruder@elecsyscorp.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from b.ns.miles-group.at ([95.130.255.144]:1660 "EHLO radon.swed.at"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1751681AbaB1JZ3 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 28 Feb 2014 04:25:29 -0500
In-Reply-To: <20140203102303.GB11829@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Andrew,

Am 03.02.2014 11:23, schrieb Christoph Hellwig:
> On Thu, Jan 30, 2014 at 09:26:54AM -0600, Andrew Ruder wrote:
>> Move sync_filesystem() after sb_prepare_remount_readonly().  If writers
>> sneak in anywhere from sync_filesystem() to sb_prepare_remount_readonly()
>> it can cause inodes to be dirtied and writeback to occur well after
>> sys_mount() has completely successfully.
>>
>> This was spotted by corrupted ubifs filesystems on reboot, but appears
>> that it can cause issues with any filesystem using writeback.
> 
> From the link that Richard posted it seems like you have a testcase.
> Can you please integrate it into xfstests so that we can properly
> regression test for this issue from now on?

Is it possible to create such a test case?
I don't know whether it is possible to trigger the issue on
a regular filesystem.
But as hch noted, it would be nice to have. :)

Thanks,
//richard