From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [PATCH] autofs4: check dev ioctl size before allocating Date: Sun, 06 Apr 2014 20:03:30 -0400 Message-ID: <5341EB52.1090704@oracle.com> References: <1394934021-16965-1-git-send-email-sasha.levin@oracle.com> <53401C11.7010601@oracle.com> <1396753403.24991.3.camel@perseus.fritz.box> <5340C5C7.9010203@oracle.com> <1396756437.24991.6.camel@perseus.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , linux-fsdevel , akpm@linux-foundation.org To: Ian Kent Return-path: In-Reply-To: <1396756437.24991.6.camel@perseus.fritz.box> Sender: autofs-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 04/05/2014 11:53 PM, Ian Kent wrote: > On Sat, 2014-04-05 at 23:11 -0400, Sasha Levin wrote: >> On 04/05/2014 11:03 PM, Ian Kent wrote: >>> On Sat, 2014-04-05 at 11:06 -0400, Sasha Levin wrote: >>>> Ping? Anyone wants to take this? >>> >>> Is this causing a problem for users? >>> If it is I'll send it to Andrew straight away. >>> >>> I do have this on my queue but don't have any other patches to send so >>> it's just sitting there. >>> >>> If it worries you I'll send it to Andrew now. >> >> It's not really a pressing issue since /dev/autofs is accessible only to >> root. I also doubt that it causes problems for actual users. >> >> If there are no issues with the patch, I think it's best if you could >> ack/sign off on it and if Andrew wants to take it now, he could. If he >> doesn't, it could wait for whenever. >> >> I just don't want it getting lost somewhere and never making it upstream. > > OK, but since I'm going to send it I looked at it a bit closer. > Shouldn't the E2BIG be ENAMETOOLONG since it's a file path that's being > passed? > > I can change that and send it if you agree with the change. Looks good to me, thanks! Thanks, Sasha