From: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
To: "willy@infradead.org" <willy@infradead.org>
Cc: "idryomov@gmail.com" <idryomov@gmail.com>,
"ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
David Howells <dhowells@redhat.com>
Subject: RE: [PATCH v2 5/7] ceph: Convert ceph_readdir_cache_control to store a folio
Date: Fri, 14 Feb 2025 19:38:36 +0000 [thread overview]
Message-ID: <534604620a32f0416d89d1e613263326e9631d23.camel@ibm.com> (raw)
In-Reply-To: <Z6-a2Qml3Bb8azaG@casper.infradead.org>
On Fri, 2025-02-14 at 19:34 +0000, Matthew Wilcox wrote:
> On Fri, Feb 14, 2025 at 07:10:26PM +0000, Viacheslav Dubeyko wrote:
> > > - cache_ctl->page = find_lock_page(&dir->i_data, ptr_pgoff);
> > > - if (!cache_ctl->page) {
> > > + cache_ctl->folio = filemap_lock_folio(&dir->i_data, ptr_pgoff);
> > > + if (IS_ERR(cache_ctl->folio)) {
> > > + cache_ctl->folio = NULL;
> > > doutc(cl, " page %lu not found\n", ptr_pgoff);
> >
> > Maybe, we need to change debug output here too?
> >
> > doutc(cl, " folio %lu not found\n", ptr_pgoff);
>
> I'm happy to make that change for the next version, or for somebody to
> make that change while applying the patches.
It's not critical one. The patch looks good.
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Thanks,
Slava.
next prev parent reply other threads:[~2025-02-14 19:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 15:57 [PATCH v2 0/7] Remove accesses to page->index from ceph Matthew Wilcox (Oracle)
2025-02-14 15:57 ` [PATCH v2 1/7] ceph: Do not look at the index of an encrypted page Matthew Wilcox (Oracle)
2025-02-14 15:57 ` [PATCH v2 2/7] ceph: Remove ceph_writepage() Matthew Wilcox (Oracle)
2025-02-14 15:57 ` [PATCH v2 3/7] ceph: Use a folio in ceph_page_mkwrite() Matthew Wilcox (Oracle)
2025-02-14 19:05 ` Viacheslav Dubeyko
2025-02-14 15:57 ` [PATCH v2 4/7] ceph: Convert ceph_find_incompatible() to take a folio Matthew Wilcox (Oracle)
2025-02-14 15:57 ` [PATCH v2 5/7] ceph: Convert ceph_readdir_cache_control to store " Matthew Wilcox (Oracle)
2025-02-14 19:10 ` Viacheslav Dubeyko
2025-02-14 19:34 ` Matthew Wilcox
2025-02-14 19:38 ` Viacheslav Dubeyko [this message]
2025-02-14 15:57 ` [PATCH v2 6/7] ceph: Convert writepage_nounlock() to write_folio_nounlock() Matthew Wilcox (Oracle)
2025-02-14 15:57 ` [PATCH v2 7/7] ceph: Use a folio in ceph_writepages_start() Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534604620a32f0416d89d1e613263326e9631d23.camel@ibm.com \
--to=slava.dubeyko@ibm.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).