From: Boaz Harrosh <openosd@gmail.com>
To: Jeff Layton <jlayton@redhat.com>, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, samba-technical@lists.samba.org,
Ganesha NFS List <nfs-ganesha-devel@lists.sourceforge.net>,
libc-alpha <libc-alpha@sourceware.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Carlos O'Donell <carlos@redhat.com>,
Stefan Metzmacher <metze@samba.org>,
Andy Lutomirski <luto@amacapital.net>,
Frank Filz <ffilzlnx@mindspring.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] locks: rename file-private locks to "open file description locks"
Date: Tue, 22 Apr 2014 17:45:31 +0300 [thread overview]
Message-ID: <5356808B.3040303@gmail.com> (raw)
In-Reply-To: <1398169383-10743-1-git-send-email-jlayton@redhat.com>
On 04/22/2014 03:23 PM, Jeff Layton wrote:
<>
>
> We're going to have to live with these for a long time, so it's
> important that we be happy with the names before we're stuck with them.
> The consensus on the lists so far is that they should be rechristened as
> "open file description locks".
>
I completely agree with the rename. (Though could you please post
the rest of the rename patches for review)
Just a very small nit. My native language is not English but I would
rather you use "file-descriptor" (with an '-' as well) and not
use "description" in the English name of the lock. This is
because stated like that, "description" might refer to the
locks and not to the file in the sentence. file-descriptor is
more clear I think. (For me it was confusing at first before I realized
what you meant)
Just my $0.017
Thanks
next prev parent reply other threads:[~2014-04-22 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 12:23 [PATCH] locks: rename file-private locks to "open file description locks" Jeff Layton
2014-04-22 14:45 ` Boaz Harrosh [this message]
2014-04-22 14:55 ` Jeff Layton
2014-04-22 15:05 ` Boaz Harrosh
2014-04-22 15:00 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5356808B.3040303@gmail.com \
--to=openosd@gmail.com \
--cc=carlos@redhat.com \
--cc=ffilzlnx@mindspring.com \
--cc=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=metze@samba.org \
--cc=mtk.manpages@gmail.com \
--cc=nfs-ganesha-devel@lists.sourceforge.net \
--cc=samba-technical@lists.samba.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).