From: Sasha Levin <sasha.levin@oracle.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Dave Jones <davej@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: fs: dcookie: freeing active timer
Date: Thu, 24 Apr 2014 13:34:14 -0400 [thread overview]
Message-ID: <53594B16.4000901@oracle.com> (raw)
In-Reply-To: <20140424172708.GY18016@ZenIV.linux.org.uk>
On 04/24/2014 01:27 PM, Al Viro wrote:
> On Thu, Apr 24, 2014 at 12:56:36PM -0400, Sasha Levin wrote:
>> > Hi all,
>> >
>> > While fuzzing with trinity inside a KVM tools guest running the latest -next
>> > kernel I've stumbled on the following:
>> > [ 191.871535] kmem_cache_destroy (mm/slab_common.c:363)
>> > [ 191.871535] dcookie_unregister (fs/dcookies.c:302 fs/dcookies.c:343)
> So it's dcookie_exit() doing kmem_cache_destroy(dcookie_cache) while
> some timer is active?
>
> Why does that code bother with destroying/creating that sucker dynamically?
> Is there any point at all?
I'm not sure about the dynamic allocation part, but I fear that if we just
switch to using static allocations it'll hide the underlying issue that
triggered this bug instead of fixing it.
Thanks,
Sasha
next prev parent reply other threads:[~2014-04-24 17:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 16:56 fs: dcookie: freeing active timer Sasha Levin
2014-04-24 17:27 ` Al Viro
2014-04-24 17:34 ` Sasha Levin [this message]
2014-04-24 21:55 ` Al Viro
2014-04-24 23:49 ` Al Viro
2014-04-25 3:31 ` Sasha Levin
2014-04-30 21:48 ` Sasha Levin
2014-04-30 23:19 ` Christoph Lameter
2014-05-01 20:10 ` Andrew Morton
2014-05-01 20:23 ` Christoph Lameter
2014-05-05 20:44 ` Sasha Levin
2014-05-05 20:51 ` Andrew Morton
2014-05-06 12:31 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53594B16.4000901@oracle.com \
--to=sasha.levin@oracle.com \
--cc=davej@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).