From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH 11/17] mm: page_alloc: Use unsigned int for order in more
 places
Date: Thu, 01 May 2014 07:35:47 -0700
Message-ID: <53625BC3.3000804@intel.com>
References: <1398933888-4940-1-git-send-email-mgorman@suse.de> <1398933888-4940-12-git-send-email-mgorman@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Johannes Weiner <hannes@cmpxchg.org>,
 Vlastimil Babka <vbabka@suse.cz>,
 Jan Kara <jack@suse.cz>, Michal Hocko <mhocko@suse.cz>,
 Hugh Dickins <hughd@google.com>,
 Linux Kernel <linux-kernel@vger.kernel.org>
To: Mel Gorman <mgorman@suse.de>, Linux-MM <linux-mm@kvack.org>,
 Linux-FSDevel <linux-fsdevel@vger.kernel.org>
Return-path: <owner-linux-mm@kvack.org>
In-Reply-To: <1398933888-4940-12-git-send-email-mgorman@suse.de>
Sender: owner-linux-mm@kvack.org
List-Id: linux-fsdevel.vger.kernel.org

On 05/01/2014 01:44 AM, Mel Gorman wrote:
> X86 prefers the use of unsigned types for iterators and there is a
> tendency to mix whether a signed or unsigned type if used for page
> order. This converts a number of sites in mm/page_alloc.c to use
> unsigned int for order where possible.

Does this actually generate any different code?  I'd actually expect
something like 'order' to be one of the easiest things for the compiler
to figure out an absolute range on.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>