From mboxrd@z Thu Jan  1 00:00:00 1970
From: Reuben Farrelly <reuben@reub.net>
Subject: Re: [PATCH] locks: only validate the lock vs. f_mode in F_SETLK codepaths
Date: Sat, 10 May 2014 09:59:58 +1000
Message-ID: <536D6BFE.7040203@reub.net>
References: <1399652489-5217-1-git-send-email-jlayton@poochiereds.net>	<20140509180744.GA9930@redhat.com> <20140509141535.13926fb8@tlielax.poochiereds.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, bfields@fieldses.org,
	swhiteho@redhat.com, ssorce@redhat.com
To: Jeff Layton <jlayton@poochiereds.net>,
	Dave Jones <davej@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from tornado.reub.net ([150.101.124.42]:32947 "EHLO tornado.reub.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756738AbaEJAJt (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 9 May 2014 20:09:49 -0400
In-Reply-To: <20140509141535.13926fb8@tlielax.poochiereds.net>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 10/05/2014 4:15 AM, Jeff Layton wrote:
> Well spotted -- that was indeed unintentional. Fixed in my repo and in
> the code in -next, but I'll refrain from re-posting for now.
>
> Clearly, I need to roll some better file locking tests... ;)
>
> Thanks,

I've just applied the following 3 patches from Jeff's git repo on top of 
a vanilla 3.15-rc5:

09e558d9baa6416111bce8610c6bbd9a525ee057 [PATCH] locks: only validate 
the lock vs. f_mode in F_SETLK codepaths

e4bf5e2a931bdf053e5bcb72ec959ee151ef2aaf [PATCH] locks: ensure that 
fl_owner is always initialized properly in flock and lease codepaths

0e71bcb3ec5d8fba7e534d379ad69933ed6493e0 [PATCH] fs/locks.c: replace 
seq_printf by seq_puts

I can confirm that this fixes the problem - in that Samba now compiles 
through to completion.

Thanks for the fix!

Reuben